[stdlib] performance optimizations in `Array.replaceSubrange` #66160

oxy · 2023-05-26T00:36:39Z

This PR is intended to generally improve performance for replaceSubrange.

Currently, it simplifies the main codepath to avoid unneeded branches.
Additional plans:

write benchmarks for replaceSubrange in a variety of contexts (replacing 1 element, 10%, 50%, and 100%, and growing/shrinking)
add an additional branch for replaceSubrange that doesn't modify an existing Array in place and instead constructs a new Array with copy/move (for non-unique / growth cases)

oxy · 2023-05-26T00:40:03Z

@swift-ci please test

oxy · 2023-05-26T02:34:42Z

@swift-ci please test

oxy · 2023-06-05T18:10:53Z

@swift-ci please benchmark

Significant changes with the original commit:

Performance (x86_64): -O

Regression	OLD	NEW	DELTA	RATIO
ArrayAppendToGeneric	293.333	500.896	+70.8%	0.59x (?)
ArrayAppendSequence	410.0	662.0	+61.5%	0.62x (?)
Dictionary4	156.0	192.5	+23.4%	0.81x (?)
UTF8Decode_InitFromCustom_contiguous	129.0	157.182	+21.8%	0.82x (?)
UTF8Decode_InitDecoding	129.077	157.167	+21.8%	0.82x (?)
ArrayAppendGenericStructs	1462.5	1770.0	+21.0%	0.83x (?)
Dictionary4OfObjects	183.5	217.857	+18.7%	0.84x
UTF8Decode_InitFromCustom_noncontiguous	250.5	279.375	+11.5%	0.90x (?)
FindString.Loop1.Substring	277.875	307.143	+10.5%	0.90x (?)

Improvement	OLD	NEW	DELTA	RATIO
NaiveRRC.append.smallContiguousRepeated	176.0	98.563	-44.0%	1.79x
FlattenListFlatMap	4324.0	2842.0	-34.3%	1.52x (?)
Array.removeAll.keepingCapacity.Object	6.63	5.224	-21.2%	1.27x (?)
RangeAssignment	155.643	134.688	-13.5%	1.16x (?)
Set.isDisjoint.Int.Empty	51.2	45.743	-10.7%	1.12x (?)
FlattenListLoop	1625.0	1478.0	-9.0%	1.10x (?)
Set.subtracting.Empty.Box	21.688	19.823	-8.6%	1.09x (?)
PrefixWhileSequence	181.4	168.75	-7.0%	1.07x (?)
PrefixWhileAnySequence	181.222	169.0	-6.7%	1.07x (?)
Set.isDisjoint.Seq.Int.Empty	53.125	49.6	-6.6%	1.07x (?)
NSStringConversion.Rebridge.LongUTF8	31.2	29.156	-6.6%	1.07x (?)

Code size: -O

Regression	OLD	NEW	DELTA	RATIO
NaiveRangeReplaceableCollectionConformance.o	11824	13644	+15.4%	0.87x

Improvement	OLD	NEW	DELTA	RATIO
RangeAssignment.o	3302	2751	-16.7%	1.20x
ArrayRemoveAll.o	7880	7594	-3.6%	1.04x
IndexPathTest.o	9941	9685	-2.6%	1.03x
RemoveWhere.o	14692	14390	-2.1%	1.02x
PopFrontGeneric.o	2470	2422	-1.9%	1.02x
MirrorTest.o	11588	11428	-1.4%	1.01x
s

Performance (x86_64): -Osize

Regression	OLD	NEW	DELTA	RATIO
UTF8Decode_InitFromCustom_contiguous	126.833	157.429	+24.1%	0.81x (?)
UTF8Decode_InitDecoding	127.615	156.917	+23.0%	0.81x (?)
UTF8Decode_InitFromCustom_noncontiguous	287.571	315.333	+9.7%	0.91x (?)

Improvement	OLD	NEW	DELTA	RATIO
StringWithCString2	0.002	0.0	-66.7%	3.00x
NaiveRRC.append.smallContiguousRepeated	176.0	94.0	-46.6%	1.87x
RemoveWhereSwapInts	15.354	11.52	-25.0%	1.33x (?)
Array.removeAll.keepingCapacity.Object	6.88	5.173	-24.8%	1.33x (?)

Code size: -Osize

Improvement	OLD	NEW	DELTA	RATIO
RangeAssignment.o	2998	2658	-11.3%	1.13x
NaiveRangeReplaceableCollectionConformance.o	11616	11058	-4.8%	1.05x
ArrayRemoveAll.o	7350	7019	-4.5%	1.05x
IndexPathTest.o	7305	7008	-4.1%	1.04x
RemoveWhere.o	12449	12106	-2.8%	1.03x
PopFrontGeneric.o	2427	2381	-1.9%	1.02x
MirrorTest.o	11460	11300	-1.4%	1.01x

Performance (x86_64): -Onone

Regression	OLD	NEW	DELTA	RATIO
UTF8Decode_InitDecoding	135.75	167.333	+23.3%	0.81x (?)
UTF8Decode_InitFromCustom_contiguous	136.083	166.923	+22.7%	0.82x (?)
NSStringConversion.InlineBuffer.ASCII	5282.0	6144.0	+16.3%	0.86x (?)
NSStringConversion.InlineBuffer.UTF8	3170.0	3605.0	+13.7%	0.88x (?)
ArrayOfGenericPOD2	1050.0	1145.0	+9.0%	0.92x (?)

Improvement	OLD	NEW	DELTA	RATIO
DataCreateMedium	159400.0	138800.0	-12.9%	1.15x (?)
CharacterLiteralsLarge	447.25	397.2	-11.2%	1.13x (?)
CxxStringConversion.cxx.to.swift	162.333	144.667	-10.9%	1.12x (?)
PopFrontArrayGeneric	3160.0	2890.0	-8.5%	1.09x (?)
BinaryFloatingPointPropertiesBinade	55.0	51.2	-6.9%	1.07x (?)
Calculator	930.0	867.0	-6.8%	1.07x (?)

Code size: -swiftlibs

oxy · 2023-06-05T20:19:41Z

@swift-ci please benchmark

oxy · 2023-06-05T21:27:31Z

Adding the extra branches to skip .deinitialize / .moveInitialize helped with some of the regressions:

Performance (x86_64): -O

Regression	OLD	NEW	DELTA	RATIO
StringWithCString2	0.0	0.002	+200.0%	0.33x (?)
InsertCharacterEndIndex	90.455	101.118	+11.8%	0.89x (?)
InsertCharacterEndIndexNonASCII	28.406	31.613	+11.3%	0.90x (?)
InsertCharacterTowardsEndIndex	103.438	113.267	+9.5%	0.91x (?)
FindString.Loop1.Substring	277.8	303.143	+9.1%	0.92x (?)
FlattenListLoop	1205.0	1313.0	+9.0%	0.92x (?)

Improvement	OLD	NEW	DELTA	RATIO
NaiveRRC.append.largeContiguous	0.124	0.0	-99.2%	125.00x (?)
NaiveRRC.append.smallContiguousRepeated	177.9	98.588	-44.6%	1.80x
LessSubstringSubstringGenericComparable	29.724	22.364	-24.8%	1.33x (?)
LessSubstringSubstring	29.625	22.318	-24.7%	1.33x (?)
EqualSubstringSubstring	30.6	23.077	-24.6%	1.33x (?)
EqualSubstringString	30.16	22.864	-24.2%	1.32x
EqualStringSubstring	30.375	23.179	-23.7%	1.31x (?)
EqualSubstringSubstringGenericEquatable	29.96	22.97	-23.3%	1.30x (?)
UTF8Decode_InitFromData	167.583	138.455	-17.4%	1.21x (?)
UTF8Decode_InitFromBytes	170.889	143.0	-16.3%	1.20x (?)
StringComparison_longSharedPrefix	246.3	209.545	-14.9%	1.18x (?)
NormalizedIterator_fastPrenormal	553.023	486.531	-12.0%	1.14x (?)
Breadcrumbs.UTF16ToIdx.longASCII	43.581	39.352	-9.7%	1.11x (?)
SortStringsUnicode	2390.0	2165.0	-9.4%	1.10x (?)
NormalizedIterator_latin1	182.1	167.636	-7.9%	1.09x (?)
Breadcrumbs.MutatedUTF16ToIdx.Mixed	210.545	195.0	-7.4%	1.08x (?)
Breadcrumbs.MutatedIdxToUTF16.Mixed	217.875	201.875	-7.3%	1.08x (?)
SubstringEqualString	181.0	168.2	-7.1%	1.08x (?)
RangeAssignment	155.5	145.0	-6.8%	1.07x (?)

Code size: -O

Regression	OLD	NEW	DELTA	RATIO
StringSplitting.o	36094	37118	+2.8%	0.97x

Improvement	OLD	NEW	DELTA	RATIO
RangeAssignment.o	3302	2767	-16.2%	1.19x
ArrayRemoveAll.o	7880	7611	-3.4%	1.04x
NaiveRangeReplaceableCollectionConformance.o	11824	11472	-3.0%	1.03x
IndexPathTest.o	9941	9733	-2.1%	1.02x
PopFrontGeneric.o	2470	2422	-1.9%	1.02x
RemoveWhere.o	14692	14407	-1.9%	1.02x
MirrorTest.o	11588	11444	-1.2%	1.01x

Performance (x86_64): -Osize

Regression	OLD	NEW	DELTA	RATIO
StringBuilderLong	778.333	916.842	+17.8%	0.85x (?)
DropLastCountableRangeLazy	4.992	5.802	+16.2%	0.86x (?)
InsertCharacterEndIndex	90.105	101.278	+12.4%	0.89x (?)
InsertCharacterEndIndexNonASCII	28.469	31.0	+8.9%	0.92x (?)
String.replaceSubrange.String	10.013	10.887	+8.7%	0.92x (?)
String.replaceSubrange.ArrChar.Small	35.781	38.654	+8.0%	0.93x (?)
InsertCharacterTowardsEndIndex	118.714	128.071	+7.9%	0.93x (?)

Improvement	OLD	NEW	DELTA	RATIO
NaiveRRC.append.smallContiguousRepeated	172.9	93.923	-45.7%	1.84x
EqualSubstringString	29.844	22.422	-24.9%	1.33x (?)
EqualSubstringSubstringGenericEquatable	29.923	22.576	-24.6%	1.33x (?)
EqualSubstringSubstring	29.844	22.576	-24.4%	1.32x (?)
EqualStringSubstring	29.826	22.633	-24.1%	1.32x
LessSubstringSubstring	30.387	23.088	-24.0%	1.32x
LessSubstringSubstringGenericComparable	30.378	23.186	-23.7%	1.31x
Array.removeAll.keepingCapacity.Object	6.875	5.432	-21.0%	1.27x (?)
UTF8Decode_InitFromData	167.5	138.385	-17.4%	1.21x (?)
UTF8Decode_InitFromBytes	175.125	146.8	-16.2%	1.19x
StringComparison_longSharedPrefix	246.9	208.545	-15.5%	1.18x (?)
Breadcrumbs.UTF16ToIdx.longASCII	44.673	39.297	-12.0%	1.14x (?)
SubstringEqualString	183.778	164.8	-10.3%	1.12x (?)
StringFromLongWholeSubstringGeneric	6.007	5.477	-8.8%	1.10x (?)
StringComparison_latin1	336.833	312.0	-7.4%	1.08x (?)
Breadcrumbs.MutatedIdxToUTF16.Mixed	217.625	202.0	-7.2%	1.08x (?)
Breadcrumbs.MutatedUTF16ToIdx.Mixed	210.636	195.636	-7.1%	1.08x (?)
SubstringEquatable	316.286	295.5	-6.6%	1.07x (?)

Code size: -Osize

Regression	OLD	NEW	DELTA	RATIO
StringSplitting.o	36281	37222	+2.6%	0.97x

Improvement	OLD	NEW	DELTA	RATIO
RangeAssignment.o	2998	2690	-10.3%	1.11x
ArrayRemoveAll.o	7350	7040	-4.2%	1.04x
IndexPathTest.o	7305	7016	-4.0%	1.04x
NaiveRangeReplaceableCollectionConformance.o	11616	11273	-3.0%	1.03x
RemoveWhere.o	12449	12142	-2.5%	1.03x
PopFrontGeneric.o	2427	2381	-1.9%	1.02x
MirrorTest.o	11460	11316	-1.3%	1.01x

Performance (x86_64): -Onone

Regression	OLD	NEW	DELTA	RATIO
Array.removeAll.keepingCapacity.Object	5.61	6.798	+21.2%	0.83x (?)
String.replaceSubrange.String	11.102	12.425	+11.9%	0.89x (?)
InsertCharacterTowardsEndIndex	131.462	144.5	+9.9%	0.91x (?)
ArrayAppendLatin1Substring	21984.0	24036.0	+9.3%	0.91x (?)
ArrayAppendAsciiSubstring	21780.0	23760.0	+9.1%	0.92x (?)
ArrayAppendUTF16Substring	21792.0	23748.0	+9.0%	0.92x (?)
InsertCharacterEndIndex	135.5	147.077	+8.5%	0.92x (?)

Improvement	OLD	NEW	DELTA	RATIO
PopFrontArrayGeneric	3158.0	2433.846	-22.9%	1.30x (?)
LessSubstringSubstringGenericComparable	33.0	25.962	-21.3%	1.27x (?)
EqualSubstringSubstringGenericEquatable	32.96	25.968	-21.2%	1.27x (?)
LessSubstringSubstring	34.69	27.5	-20.7%	1.26x
EqualSubstringSubstring	34.327	27.469	-20.0%	1.25x (?)
EqualSubstringString	34.5	27.636	-19.9%	1.25x (?)
EqualStringSubstring	34.043	27.455	-19.4%	1.24x (?)
UTF8Decode_InitFromData	169.2	139.538	-17.5%	1.21x (?)
UTF8Decode_InitFromBytes	173.667	145.0	-16.5%	1.20x (?)
DataCreateMedium	159500.0	138700.0	-13.0%	1.15x (?)
DataCreateSmall	21850.0	19390.0	-11.3%	1.13x (?)
RangeAssignment	11807.0	10685.0	-9.5%	1.11x (?)
Breadcrumbs.MutatedUTF16ToIdx.Mixed	221.1	203.9	-7.8%	1.08x (?)
Breadcrumbs.MutatedIdxToUTF16.Mixed	228.429	210.818	-7.7%	1.08x (?)

oxy · 2023-06-05T22:21:34Z

@swift-ci please benchmark

Another commit, another set of benchmarks:

Performance (x86_64): -O

Regression	OLD	NEW	DELTA	RATIO
StringWithCString2	0.0	0.002	+200.0%	0.33x (?)
ArrayAppendGenericStructs	1442.0	1710.0	+18.6%	0.84x (?)
NormalizedIterator_emoji	331.429	377.92	+14.0%	0.88x (?)
String.replaceSubrange.Substring.Small	39.286	43.75	+11.4%	0.90x (?)
FindString.Loop1.Substring	278.625	306.0	+9.8%	0.91x (?)
NormalizedIterator_nonBMPSlowestPrenormal	418.75	458.889	+9.6%	0.91x (?)
InsertCharacterEndIndex	90.5	99.05	+9.4%	0.91x (?)
InsertCharacterTowardsEndIndex	103.588	112.933	+9.0%	0.92x (?)
String.replaceSubrange.ArrChar.Small	36.444	39.462	+8.3%	0.92x (?)
InsertCharacterStartIndex	255.278	275.625	+8.0%	0.93x (?)

Improvement	OLD	NEW	DELTA	RATIO
NaiveRRC.append.smallContiguousRepeated	178.7	102.625	-42.6%	1.74x
FlattenListLoop	1621.0	1021.0	-37.0%	1.59x (?)
LessSubstringSubstring	29.875	22.42	-25.0%	1.33x (?)
LessSubstringSubstringGenericComparable	29.719	22.422	-24.6%	1.33x (?)
EqualSubstringSubstring	30.6	23.308	-23.8%	1.31x (?)
RangeAssignment	155.444	118.643	-23.7%	1.31x (?)
EqualSubstringString	30.051	22.97	-23.6%	1.31x (?)
EqualSubstringSubstringGenericEquatable	29.938	23.056	-23.0%	1.30x (?)
EqualStringSubstring	30.276	23.4	-22.7%	1.29x
UTF8Decode_InitFromData	171.455	136.833	-20.2%	1.25x (?)
UTF8Decode_InitFromBytes	172.6	140.0	-18.9%	1.23x
Set.isDisjoint.Int.Empty	51.2	45.74	-10.7%	1.12x (?)
CxxStringConversion.cxx.to.swift	156.333	140.5	-10.1%	1.11x (?)
Data.init.Sequence.809B.Count.RE.I	22.963	20.788	-9.5%	1.10x (?)
Breadcrumbs.MutatedUTF16ToIdx.Mixed	210.636	191.364	-9.1%	1.10x (?)
Breadcrumbs.MutatedIdxToUTF16.Mixed	218.0	198.222	-9.1%	1.10x (?)
Set.subtracting.Empty.Box	21.64	19.824	-8.4%	1.09x (?)
SortStringsUnicode	2387.5	2192.5	-8.2%	1.09x (?)
Data.init.Sequence.809B.Count.RE	23.042	21.333	-7.4%	1.08x (?)
FlattenListFlatMap	3033.0	2816.0	-7.2%	1.08x (?)
Set.isDisjoint.Seq.Int.Empty	53.13	49.36	-7.1%	1.08x (?)
ArraySetElement	306.5	286.143	-6.6%	1.07x (?)

Code size: -O

Regression	OLD	NEW	DELTA	RATIO
StringSplitting.o	36094	37118	+2.8%	0.97x

Improvement	OLD	NEW	DELTA	RATIO
RangeAssignment.o	3302	2703	-18.1%	1.22x
NaiveRangeReplaceableCollectionConformance.o	11824	10704	-9.5%	1.10x
ArrayRemoveAll.o	7880	7611	-3.4%	1.04x
IndexPathTest.o	9941	9733	-2.1%	1.02x
PopFrontGeneric.o	2470	2422	-1.9%	1.02x
RemoveWhere.o	14692	14407	-1.9%	1.02x
MirrorTest.o	11588	11444	-1.2%	1.01x

Performance (x86_64): -Osize

Regression	OLD	NEW	DELTA	RATIO
SuffixAnySequence	98.75	1587.0	+1507.1%	0.06x
SuffixSequence	115.692	1698.0	+1367.7%	0.07x
SuffixSequenceLazy	115.455	1607.0	+1291.9%	0.07x
SuffixCountableRangeLazy	5.249	9.0	+71.4%	0.58x (?)
ArrayAppendGenericStructs	1064.0	1756.667	+65.1%	0.61x (?)
PrefixAnySeqCntRangeLazy	121.077	134.25	+10.9%	0.90x (?)
NormalizedIterator_nonBMPSlowestPrenormal	415.254	458.293	+10.4%	0.91x (?)
NormalizedIterator_emoji	331.04	365.0	+10.3%	0.91x (?)
InsertCharacterEndIndex	89.947	99.105	+10.2%	0.91x (?)
String.replaceSubrange.Substring.Small	39.818	43.5	+9.2%	0.92x (?)
String.replaceSubrange.ArrChar.Small	35.815	39.08	+9.1%	0.92x (?)
StringEnumRawValueInitialization	450.0	488.8	+8.6%	0.92x (?)
FindString.Loop1.Substring	283.0	307.143	+8.5%	0.92x (?)
InsertCharacterTowardsEndIndex	118.429	127.923	+8.0%	0.93x (?)

Improvement	OLD	NEW	DELTA	RATIO
NaiveRRC.append.largeContiguous	0.39	0.104	-73.1%	3.72x (?)
NaiveRRC.append.smallContiguousRepeated	176.0	102.688	-41.7%	1.71x
EqualSubstringSubstringGenericEquatable	29.923	22.606	-24.5%	1.32x
EqualSubstringString	29.844	22.6	-24.3%	1.32x (?)
EqualSubstringSubstring	29.833	22.606	-24.2%	1.32x (?)
EqualStringSubstring	29.826	22.621	-24.2%	1.32x (?)
LessSubstringSubstring	30.375	23.286	-23.3%	1.30x (?)
LessSubstringSubstringGenericComparable	30.385	23.515	-22.6%	1.29x (?)
RangeAssignment	158.455	126.818	-20.0%	1.25x (?)
UTF8Decode_InitFromData	167.4	134.417	-19.7%	1.25x (?)
UTF8Decode_InitFromBytes	171.0	137.417	-19.6%	1.24x (?)
PrefixAnyCollection	137.273	110.733	-19.3%	1.24x (?)
PrefixWhileAnyCollectionLazy	147.769	121.143	-18.0%	1.22x (?)
StringComparison_longSharedPrefix	246.3	206.1	-16.3%	1.20x (?)
DropFirstAnySeqCntRange	120.714	107.333	-11.1%	1.12x (?)
DropFirstAnySeqCRangeIter	120.625	107.333	-11.0%	1.12x (?)
Breadcrumbs.MutatedUTF16ToIdx.Mixed	210.5	191.364	-9.1%	1.10x (?)
Breadcrumbs.MutatedIdxToUTF16.Mixed	217.5	198.111	-8.9%	1.10x (?)
Array.removeAll.keepingCapacity.Object	5.841	5.361	-8.2%	1.09x (?)

Code size: -Osize

Regression	OLD	NEW	DELTA	RATIO
Suffix.o	17680	22991	+30.0%	0.77x
StringSplitting.o	36281	37222	+2.6%	0.97x

Improvement	OLD	NEW	DELTA	RATIO
RangeAssignment.o	2998	2615	-12.8%	1.15x
ArrayRemoveAll.o	7350	7040	-4.2%	1.04x
IndexPathTest.o	7305	7016	-4.0%	1.04x
NaiveRangeReplaceableCollectionConformance.o	11616	11258	-3.1%	1.03x
RemoveWhere.o	12449	12142	-2.5%	1.03x
PopFrontGeneric.o	2427	2381	-1.9%	1.02x
MirrorTest.o	11460	11316	-1.3%	1.01x

Performance (x86_64): -Onone

Regression	OLD	NEW	DELTA	RATIO
SubstringRemoveFirst1	0.143	0.167	+16.7%	0.86x (?)
String.replaceSubrange.Substring.Small	40.98	45.68	+11.5%	0.90x (?)
String.replaceSubrange.ArrChar.Small	36.92	41.143	+11.4%	0.90x (?)
InsertCharacterTowardsEndIndex	131.769	142.385	+8.1%	0.93x (?)
ArrayOfGenericPOD2	1049.0	1130.0	+7.7%	0.93x (?)

Improvement	OLD	NEW	DELTA	RATIO
NaiveRRC.append.largeContiguous	109.0	0.458	-99.6%	237.47x
NaiveRRC.init.largeContiguous	103.75	0.49	-99.5%	211.31x
RangeAssignment	11501.0	5693.0	-50.5%	2.02x
NaiveRRC.append.smallContiguousRepeated	2286.0	1668.0	-27.0%	1.37x (?)
PopFrontArrayGeneric	3160.0	2406.667	-23.8%	1.31x (?)
EqualSubstringSubstringGenericEquatable	32.88	25.935	-21.1%	1.27x (?)
LessSubstringSubstring	34.966	27.719	-20.7%	1.26x (?)
UTF8Decode_InitFromData	167.9	133.727	-20.4%	1.26x (?)
LessSubstringSubstringGenericComparable	32.548	26.0	-20.1%	1.25x (?)
UTF8Decode_InitFromBytes	172.667	138.333	-19.9%	1.25x (?)
EqualSubstringString	34.417	27.687	-19.6%	1.24x (?)
EqualSubstringSubstring	34.25	27.667	-19.2%	1.24x
EqualStringSubstring	34.182	27.857	-18.5%	1.23x (?)
DataCreateMedium	160600.0	137200.0	-14.6%	1.17x (?)
DataCreateSmall	21700.0	19030.0	-12.3%	1.14x (?)
Breadcrumbs.MutatedIdxToUTF16.Mixed	228.0	208.182	-8.7%	1.10x (?)

Catfish-Man · 2023-06-05T23:31:49Z

stdlib/public/core/ArrayBufferProtocol.swift

+    // place the values into the hole we created
+    if newCount > 0 {
+      let done: Void? = newValues.withContiguousStorageIfAvailable {
+        holeStart.initialize(from: $0.baseAddress!, count: newCount)


It's so annoying that withContiguousStorageIfAvailable is allowed to pass a buffer with a nil baseAddress rather than just returning nil without executing the closure in that case. Otherwise we could use .unsafelyUnwrappedUnchecked here.

(Actually what IS supposed to happen in that case? Should it just be the same as if newValues was empty?)

well, it says that if there is no contiguous representation, it should ignore body and just return nil?
and in this case, newValues.count / newCount should be the same (and from above, > 0) for a well-implemented collection?

I'm not sure if its worth throwing in an extra assert for $0.count == newCount, or removing ! for .unsafelyUnwrappedUnchecked either.

oxy · 2023-06-06T01:01:42Z

@swift-ci please benchmark

oxy · 2023-06-06T18:02:33Z

@swift-ci please benchmark

oxy · 2023-06-07T19:53:17Z

@swift-ci please benchmark Apple Silicon

oxy · 2023-06-07T20:05:03Z

@swift-ci Please Apple Silicon benchmark

The AS results are less noisy, but also highlight a different regression (???)

Performance (arm64): -O

Regression	OLD	NEW	DELTA	RATIO
RemoveWhereQuadraticString	167.0	210.583	+26.1%	0.79x (?)
NSStringConversion.InlineBuffer.UTF8	469.667	505.5	+7.6%	0.93x (?)

Improvement	OLD	NEW	DELTA	RATIO
NaiveRRC.append.smallContiguousRepeated	75.762	55.438	-26.8%	1.37x (?)
SIMDReduce.Int32x16.Initializer	13.036	11.075	-15.0%	1.18x (?)
Set.isDisjoint.Seq.Empty.Box	45.241	39.0	-13.8%	1.16x (?)
ObserverForwarderStruct	203.846	186.154	-8.7%	1.10x (?)

Code size: -O

Regression	OLD	NEW	DELTA	RATIO
StringSplitting.o	27959	28675	+2.6%	0.98x

Improvement	OLD	NEW	DELTA	RATIO
RangeAssignment.o	2889	2197	-24.0%	1.31x
NaiveRangeReplaceableCollectionConformance.o	8022	7190	-10.4%	1.12x
ArrayRemoveAll.o	6060	5704	-5.9%	1.06x
IndexPathTest.o	7978	7710	-3.4%	1.03x
RemoveWhere.o	11280	10916	-3.2%	1.03x
MirrorTest.o	8490	8310	-2.1%	1.02x
PopFrontGeneric.o	2009	1973	-1.8%	1.02x

Performance (arm64): -Osize

Regression	OLD	NEW	DELTA	RATIO
SuffixSequenceLazy	88.409	704.0	+696.3%	0.13x
SuffixAnySequence	88.409	678.0	+666.9%	0.13x
SuffixSequence	88.423	677.667	+666.4%	0.13x
NSStringConversion.InlineBuffer.UTF8	469.667	506.0	+7.7%	0.93x

Improvement	OLD	NEW	DELTA	RATIO
NaiveRRC.append.largeContiguous	0.389	0.0	-99.7%	390.00x
NaiveRRC.append.smallContiguousRepeated	77.25	57.0	-26.2%	1.36x
RangeAssignment	155.727	143.643	-7.8%	1.08x (?)

Code size: -Osize

Regression	OLD	NEW	DELTA	RATIO
Suffix.o	13712	17404	+26.9%	0.79x
StringSplitting.o	24583	25027	+1.8%	0.98x

Improvement	OLD	NEW	DELTA	RATIO
RangeAssignment.o	2617	2205	-15.7%	1.19x
ArrayRemoveAll.o	6096	5708	-6.4%	1.07x
NaiveRangeReplaceableCollectionConformance.o	7994	7494	-6.3%	1.07x
IndexPathTest.o	6194	5902	-4.7%	1.05x
RemoveWhere.o	10036	9656	-3.8%	1.04x
MirrorTest.o	8130	7946	-2.3%	1.02x
PopFrontGeneric.o	2065	2021	-2.1%	1.02x

Performance (arm64): -Onone

Regression	OLD	NEW	DELTA	RATIO
ArrayOfGenericPOD2	855.0	1170.0	+36.8%	0.73x (?)
Set.filter.Int100.24k	62.575	69.714	+11.4%	0.90x (?)
Set.filter.Int100.20k	52.596	58.488	+11.2%	0.90x
Set.filter.Int100.16k	42.586	47.241	+10.9%	0.90x
Set.filter.Int100.28k	75.03	83.1	+10.8%	0.90x (?)
StringWordBuilderReservingCapacity	811.667	875.0	+7.8%	0.93x (?)

Improvement	OLD	NEW	DELTA	RATIO
NaiveRRC.append.largeContiguous	53.167	0.278	-99.5%	190.57x
NaiveRRC.init.largeContiguous	53.295	0.288	-99.5%	184.42x
RangeAssignment	5628.0	2854.0	-49.3%	1.97x
NaiveRRC.append.smallContiguousRepeated	1234.5	957.5	-22.4%	1.29x
PopFrontArrayGeneric	2456.0	2061.25	-16.1%	1.19x (?)

oxy · 2023-06-08T07:36:18Z

@swift-ci please benchmark

oxy · 2023-06-08T07:36:29Z

@swift-ci please apple silicon benchmark

oxy · 2023-06-08T07:38:28Z

[removed one of the three branches that could have potentially introduced a regression in the Suffix benchmarks - working on better understanding for optimizer behavior on the other two to potentially fix the regression]

oxy · 2023-06-08T15:27:17Z

@swift-ci please benchmark

oxy · 2023-06-08T15:27:27Z

@swift-ci please apple silicon benchmark

oxy · 2023-06-09T18:25:30Z

@swift-ci please benchmark

oxy · 2023-06-09T18:25:40Z

@swift-ci please apple silicon benchmark

harlanhaskins · 2023-06-18T19:19:37Z

@swift-ci please benchmark

oxy · 2023-08-02T17:52:32Z

@swift-ci please apple silicon benchmark

oxy · 2023-08-02T19:56:08Z

Test again, same results:

Performance (arm64): -O

Regression	OLD	NEW	DELTA	RATIO
Set.isSuperset.Seq.Empty.Int	34.303	40.55	+18.2%	0.85x
DataAppendBytesSmall	121.667	134.143	+10.3%	0.91x (?)

Improvement	OLD	NEW	DELTA	RATIO
NaiveRRC.append.smallContiguousRepeated	75.727	55.529	-26.7%	1.36x
ObserverForwarderStruct	219.583	197.308	-10.1%	1.11x (?)
NSStringConversion.InlineBuffer.UTF8	500.5	464.333	-7.2%	1.08x (?)
StringInterpolationSmall	533.889	496.923	-6.9%	1.07x (?)

Code size: -O

Regression	OLD	NEW	DELTA	RATIO
NaiveRangeReplaceableCollectionConformance.o	8090	9326	+15.3%	0.87x

Improvement	OLD	NEW	DELTA	RATIO
RangeAssignment.o	2885	2165	-25.0%	1.33x
ArrayRemoveAll.o	6136	5792	-5.6%	1.06x
IndexPathTest.o	7974	7686	-3.6%	1.04x
RemoveWhere.o	11152	10760	-3.5%	1.04x
MirrorTest.o	8546	8330	-2.5%	1.03x
PopFrontGeneric.o	1997	1961	-1.8%	1.02x

Performance (arm64): -Osize

Regression	OLD	NEW	DELTA	RATIO
SuffixSequenceLazy	87.773	703.333	+701.3%	0.12x
SuffixAnySequence	87.714	677.0	+671.8%	0.13x
SuffixSequence	87.773	677.0	+671.3%	0.13x
ArrayInClass	156.034	187.239	+20.0%	0.83x
DistinctClassFieldAccesses	35.928	42.169	+17.4%	0.85x
ArraySetElement	218.545	249.75	+14.3%	0.88x
Array2D	5586.286	6237.333	+11.7%	0.90x
DropLastAnySeqCntRange	278.714	310.714	+11.5%	0.90x (?)
DropLastAnySeqCRangeIter	278.625	310.571	+11.5%	0.90x
DataAppendBytesSmall	134.143	146.636	+9.3%	0.91x (?)
PrefixWhileSequence	214.9	233.444	+8.6%	0.92x (?)
PrefixWhileAnySequence	214.9	233.444	+8.6%	0.92x
DictionaryBridgeToObjC_Bridge	6.489	6.988	+7.7%	0.93x (?)

Improvement	OLD	NEW	DELTA	RATIO
NaiveRRC.append.smallContiguousRepeated	77.278	58.5	-24.3%	1.32x (?)
RangeAssignment	164.667	143.538	-12.8%	1.15x
DataAppendArray	2256.41	2052.941	-9.0%	1.10x (?)
NSStringConversion.InlineBuffer.UTF8	500.667	465.333	-7.1%	1.08x (?)
StringInterpolationSmall	549.565	512.0	-6.8%	1.07x (?)
FindString.Rec3.Array	95.192	88.9	-6.6%	1.07x (?)

Code size: -Osize

Regression	OLD	NEW	DELTA	RATIO
Suffix.o	13684	17352	+26.8%	0.79x
StringSplitting.o	24283	24535	+1.0%	0.99x

Improvement	OLD	NEW	DELTA	RATIO
RangeAssignment.o	2617	2197	-16.0%	1.19x
NaiveRangeReplaceableCollectionConformance.o	7970	7282	-8.6%	1.09x
ArrayRemoveAll.o	6152	5784	-6.0%	1.06x
IndexPathTest.o	6186	5886	-4.8%	1.05x
RemoveWhere.o	9976	9544	-4.3%	1.05x
MirrorTest.o	8214	8006	-2.5%	1.03x
PopFrontGeneric.o	2053	2009	-2.1%	1.02x

Performance (arm64): -Onone

Regression	OLD	NEW	DELTA	RATIO
ArrayAppendGenericStructs	706.154	872.727	+23.6%	0.81x (?)
PopFrontArrayGeneric	2461.25	2994.545	+21.7%	0.82x
DataCreateMedium	88400.0	101300.0	+14.6%	0.87x
RandomDoubleLCG	15110.0	17028.0	+12.7%	0.89x (?)
DataCreateSmall	12215.0	13700.0	+12.2%	0.89x (?)
Set.filter.Int100.24k	62.575	69.714	+11.4%	0.90x (?)
Set.filter.Int100.20k	52.587	58.469	+11.2%	0.90x (?)
Set.filter.Int100.16k	42.604	47.24	+10.9%	0.90x
Set.filter.Int100.28k	75.03	83.067	+10.7%	0.90x
TypeName	830.0	897.5	+8.1%	0.92x (?)
StringWordBuilderReservingCapacity	812.5	874.286	+7.6%	0.93x (?)

Improvement	OLD	NEW	DELTA	RATIO
NaiveRRC.init.largeContiguous	53.417	0.296	-99.4%	179.86x
NaiveRRC.append.largeContiguous	53.467	0.3	-99.4%	177.63x
RangeAssignment	5662.0	2852.0	-49.6%	1.99x
NaiveRRC.append.smallContiguousRepeated	1224.5	974.0	-20.5%	1.26x (?)
RawBuffer.1000.findLast	66422.0	55569.0	-16.3%	1.20x
RawBuffer.128.findLast	9080.0	7733.0	-14.8%	1.17x (?)
RawBuffer.39.findLast	3307.0	2924.0	-11.6%	1.13x (?)
ObjectiveCBridgeStubToNSString	1220.0	1127.143	-7.6%	1.08x (?)

Code size: -swiftlibs

How to read the data

The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview

  Model Name: Mac mini
  Model Identifier: Macmini9,1
  Total Number of Cores: 8 (4 performance and 4 efficiency)
  Memory: 16 GB

lorentey · 2023-08-02T23:59:08Z

stdlib/public/core/CollectionOfOne.swift

+extension CollectionOfOne: Sequence {
+  // `mutating` since `withUnsafePointer` needs inout.
+  @inlinable // trivial-implementation
+  public mutating func withContiguousStorageIfAvailable<R>(


We'll need to get rid of this for now.

lorentey

LGTM 👍

oxy · 2023-08-09T17:54:30Z

@swift-ci please test

oxy · 2023-08-10T00:12:25Z

@swift-ci please test

oxy · 2023-08-10T22:05:59Z

@swift-ci please test

glessard

Nice work!

oxy · 2023-08-14T16:52:52Z

@swift-ci Please clean test Linux platform

oxy · 2023-08-18T19:04:55Z

I haven't been able to reproduce the test failures locally on a Ubuntu 20.04 Intel container that ran the same buildbot_linux preset. I'm not sure what the source of the failure is, since it appears to crash in libc in the stdlibUnittest code, but it passes locally.

It doesn't appear to be flakiness, since multiple runs on multiple platforms had the test pass locally but the test still fails in CI.

Catfish-Man · 2024-02-28T21:15:17Z

@swift-ci please test

oxy · 2024-02-28T21:16:12Z

I think something in the past ~half year fixed it - I rebased onto main and could not reproduce the failures with buildbot_linux anymore! Hopefully the same is true in CI...

oxy · 2024-02-28T21:16:25Z

@swift-ci please test

EDIT: I finally know what tests are failing in release mode and why:

NoBoundsCheck/EvilShrinkage/*:

expected/old release behavior: just keep forming indexes and reading past reported endIndex
old DebugAssert behavior: _debugPrecondition to abort on collection shrinkage
new behavior: stop at endIndex, see that buffer is underfull, always abort

BoundsChecked/EvilGrowth/*:

expected/old release behavior: stop reading at first reported count, ignore growth
old DebugAssert behavior: _debugPrecondition to abort on collection growth
new behavior: continues reading past the old count, always aborts because the hole we created in the array is not large enough (abort generated by UMBP.initialize(fromContentsOf:))

Add an explanation about why UMBP.initialize(fromContentsOf:) can't be used.

Catfish-Man · 2024-02-29T02:52:12Z

@swift-ci please test

Catfish-Man · 2024-02-29T02:52:18Z

@swift-ci please benchmark

Catfish-Man · 2024-02-29T02:52:30Z

@swift-ci Please Apple Silicon benchmark

oxy · 2024-02-29T03:59:39Z

new performance results are in! the Suffix* benchmarks no longer have major regressions, but there are a few things I might want to investigate:

Performance (x86_64): -O

Regression	OLD	NEW	DELTA	RATIO
StringWithCString2	0.0	0.001	+100.0%	0.50x (?)
ArrayAppendGenericStructs	1425.0	1765.0	+23.9%	0.81x (?)
StringInterpolationManySmallSegments	6164.286	6822.222	+10.7%	0.90x (?)
CharacterRecognizer.ascii	90.64	99.688	+10.0%	0.91x (?)
StringBuilder	234.75	257.0	+9.5%	0.91x (?)
StringBuilderSmallReservingCapacity	242.857	263.571	+8.5%	0.92x (?)
String.initRepeating.1AsciiChar.Count100	484.0	522.667	+8.0%	0.93x (?)

Improvement	OLD	NEW	DELTA	RATIO
NaiveRRC.init.largeContiguous	22.256	5.654	-74.6%	3.94x
NaiveRRC.append.largeContiguous	22.171	5.923	-73.3%	3.74x
NaiveRRC.append.smallContiguousRepeated	163.667	92.882	-43.2%	1.76x
FlattenListLoop	1621.0	979.5	-39.6%	1.65x (?)
RangeAssignment	162.6	134.364	-17.4%	1.21x (?)
UTF8Decode_InitFromCustom_contiguous	168.818	139.769	-17.2%	1.21x (?)
UTF8Decode_InitDecoding	170.364	141.417	-17.0%	1.20x (?)
UTF8Decode_InitFromCustom_noncontiguous	209.889	181.6	-13.5%	1.16x (?)
StringFromLongWholeSubstring	3.23	2.823	-12.6%	1.14x (?)
LineSink.bytes.complex	69.875	62.25	-10.9%	1.12x (?)
LineSink.scalars.complex	69.848	62.263	-10.9%	1.12x (?)
StringSwitch	246.0	222.286	-9.6%	1.11x (?)

Code size: -O

Improvement	OLD	NEW	DELTA	RATIO
RangeAssignment.o	3254	2671	-17.9%	1.22x
ArrayRemoveAll.o	7860	7631	-2.9%	1.03x
IndexPathTest.o	9909	9653	-2.6%	1.03x
RemoveWhere.o	13840	13515	-2.3%	1.02x
PopFrontGeneric.o	2470	2422	-1.9%	1.02x
MirrorTest.o	11636	11460	-1.5%	1.02x

Performance (x86_64): -Osize

Regression	OLD	NEW	DELTA	RATIO
RemoveWhereMoveInts	6.836	11.753	+71.9%	0.58x (?)
OpenClose	52.231	58.821	+12.6%	0.89x (?)
Chars2	3236.0	3642.857	+12.6%	0.89x (?)
Calculator	152.75	168.727	+10.5%	0.91x (?)
StringBuilder	236.333	257.0	+8.7%	0.92x (?)
FlattenListFlatMap	4244.0	4598.0	+8.3%	0.92x (?)
StringBuilderSmallReservingCapacity	244.0	263.571	+8.0%	0.93x (?)
Data.hash.Medium	28.091	30.258	+7.7%	0.93x (?)

Improvement	OLD	NEW	DELTA	RATIO
NaiveRRC.init.largeContiguous	22.533	5.95	-73.6%	3.79x
NaiveRRC.append.largeContiguous	22.528	6.118	-72.8%	3.68x
NaiveRRC.append.smallContiguousRepeated	163.727	94.0	-42.6%	1.74x
FlattenListLoop	1641.0	987.0	-39.9%	1.66x (?)
RemoveWhereSwapInts	18.041	11.813	-34.5%	1.53x (?)
Array.removeAll.keepingCapacity.Object	7.769	5.709	-26.5%	1.36x (?)
RangeAssignment	177.333	142.25	-19.8%	1.25x (?)
UTF8Decode_InitDecoding	169.125	140.636	-16.8%	1.20x (?)
UTF8Decode_InitFromCustom_contiguous	169.909	142.615	-16.1%	1.19x (?)
NormalizedIterator_fastPrenormal	542.826	492.245	-9.3%	1.10x (?)
StringFromLongWholeSubstring	3.37	3.067	-9.0%	1.10x (?)
UTF8Decode_InitFromCustom_contiguous_ascii	200.2	184.4	-7.9%	1.09x (?)

Code size: -Osize

Improvement	OLD	NEW	DELTA	RATIO
RangeAssignment.o	2866	2488	-13.2%	1.15x
ArrayRemoveAll.o	7123	6895	-3.2%	1.03x
IndexPathTest.o	7113	6888	-3.2%	1.03x
RemoveWhere.o	11958	11583	-3.1%	1.03x
PopFrontGeneric.o	2312	2262	-2.2%	1.02x
MirrorTest.o	11417	11245	-1.5%	1.02x

Performance (x86_64): -Onone

Regression	OLD	NEW	DELTA	RATIO
StringWithCString2	0.004	0.006	+40.0%	0.71x (?)
ArrayAppendGenericStructs	1415.0	1835.0	+29.7%	0.77x (?)
CharacterLiteralsLarge	338.5	378.4	+11.8%	0.89x (?)
SubstringRemoveFirst1	0.2	0.222	+10.9%	0.90x (?)
ObjectiveCBridgeStubNSDateRefAccess	3361.0	3666.0	+9.1%	0.92x (?)

Improvement	OLD	NEW	DELTA	RATIO
RangeAssignment	10031.0	5007.0	-50.1%	2.00x
PopFrontArrayGeneric	3546.0	2569.231	-27.5%	1.38x (?)
UTF8Decode_InitFromCustom_contiguous	180.0	150.167	-16.6%	1.20x (?)
UTF8Decode_InitDecoding	177.5	148.25	-16.5%	1.20x (?)
NSStringConversion.InlineBuffer.ASCII	5984.0	5373.0	-10.2%	1.11x (?)
NSStringConversion.InlineBuffer.UTF8	3589.0	3301.0	-8.0%	1.09x (?)
ArrayAppendLatin1Substring	26316.0	24408.0	-7.3%	1.08x (?)

Code size: -swiftlibs

Improvement	OLD	NEW	DELTA	RATIO
libswiftSwiftOnoneSupport.dylib	163840	147456	-10.0%	1.11x
libswift_Backtracing.dylib	327680	311296	-5.0%	1.05x

oxy · 2024-02-29T04:21:11Z

Oh, Apple Silicon benchmarks have a clearer cut case:

Performance (arm64): -O

Regression	OLD	NEW	DELTA	RATIO
CxxStringConversion.cxx.to.swift	73.462	80.9	+10.1%	0.91x (?)
ArrayAppendAscii	1674.293	1802.81	+7.7%	0.93x (?)

Improvement	OLD	NEW	DELTA	RATIO
NaiveRRC.init.largeContiguous	9.528	3.546	-62.8%	2.69x
NaiveRRC.append.largeContiguous	9.52	3.546	-62.7%	2.68x
NaiveRRC.append.smallContiguousRepeated	63.135	41.289	-34.6%	1.53x
DataAppendDataMediumToMedium	1900.0	1616.0	-14.9%	1.18x (?)
Data.append.Sequence.809B.Count	21.806	18.96	-13.1%	1.15x (?)
Data.append.Sequence.809B.Count.I	21.144	18.968	-10.3%	1.11x (?)
ArrayAppendStrings	1588.0	1460.0	-8.1%	1.09x (?)
InsertCharacterEndIndex	63.714	59.026	-7.4%	1.08x
Data.append.Sequence.809B.Count.RE	23.979	22.221	-7.3%	1.08x (?)

Code size: -O

Improvement	OLD	NEW	DELTA	RATIO
RangeAssignment.o	2821	2133	-24.4%	1.32x
NaiveRangeReplaceableCollectionConformance.o	7302	6846	-6.2%	1.07x
ArrayRemoveAll.o	6032	5728	-5.0%	1.05x
RemoveWhere.o	10932	10580	-3.2%	1.03x
IndexPathTest.o	8038	7814	-2.8%	1.03x
MirrorTest.o	8498	8302	-2.3%	1.02x
PopFrontGeneric.o	2009	1973	-1.8%	1.02x

Performance (arm64): -Osize

Regression	OLD	NEW	DELTA	RATIO
ArrayLiteral2	81.138	93.6	+15.4%	0.87x
DataAppendDataMediumToMedium	1633.793	1773.6	+8.6%	0.92x (?)

Improvement	OLD	NEW	DELTA	RATIO
NaiveRRC.init.largeContiguous	10.124	3.843	-62.0%	2.63x
NaiveRRC.append.largeContiguous	10.125	3.844	-62.0%	2.63x
NaiveRRC.append.smallContiguousRepeated	64.694	39.724	-38.6%	1.63x
RangeAssignment	158.692	140.8	-11.3%	1.13x (?)
Join	79.857	72.688	-9.0%	1.10x (?)
ArrayAppendStrings	1601.0	1470.0	-8.2%	1.09x (?)
InsertCharacterEndIndex	68.406	63.735	-6.8%	1.07x

Code size: -Osize

Improvement	OLD	NEW	DELTA	RATIO
RangeAssignment.o	2441	2101	-13.9%	1.16x
NaiveRangeReplaceableCollectionConformance.o	7274	6854	-5.8%	1.06x
ArrayRemoveAll.o	5860	5556	-5.2%	1.05x
RemoveWhere.o	9216	8808	-4.4%	1.05x
IndexPathTest.o	6018	5786	-3.9%	1.04x
MirrorTest.o	8098	7910	-2.3%	1.02x
PopFrontGeneric.o	1961	1917	-2.2%	1.02x

Performance (arm64): -Onone

Regression	OLD	NEW	DELTA	RATIO
IndexPath.Max	183.091	215.0	+17.4%	0.85x
IndexPath.Min	182.385	209.182	+14.7%	0.87x

Improvement	OLD	NEW	DELTA	RATIO
StringWithCString2	0.005	0.0	-83.3%	6.00x (?)
RangeAssignment	3898.0	2151.0	-44.8%	1.81x
PopFrontArrayGeneric	2451.25	2141.905	-12.6%	1.14x
UTF8Decode_InitFromCustom_noncontiguous_ascii	36189.0	32997.0	-8.8%	1.10x
UTF8Decode_InitFromCustom_noncontiguous_ascii_as_ascii	36196.0	33008.0	-8.8%	1.10x
UTF8Decode_InitFromCustom_noncontiguous	11469.0	10517.0	-8.3%	1.09x
ArrayAppendStrings	1597.5	1466.364	-8.2%	1.09x (?)

Code size: -swiftlibs

Improvement	OLD	NEW	DELTA	RATIO
libswiftSwiftOnoneSupport.dylib	163840	147456	-10.0%	1.11x
libswift_Backtracing.dylib	327680	311296	-5.0%	1.05x

Catfish-Man · 2024-02-29T04:31:39Z

Yeah these results look great :) nicely done

glessard

Once again: 👍🏽

oxy force-pushed the rdar95802178 branch from 3e47397 to 0083f52 Compare May 26, 2023 17:40

oxy force-pushed the rdar95802178 branch from 0083f52 to e32b082 Compare June 5, 2023 18:10

Catfish-Man reviewed Jun 5, 2023

View reviewed changes

oxy force-pushed the rdar95802178 branch from 6859795 to ab9b599 Compare June 6, 2023 18:01

oxy force-pushed the rdar95802178 branch from ab9b599 to 0aafb38 Compare June 8, 2023 07:34

oxy force-pushed the rdar95802178 branch from 7c8c87f to 5efc740 Compare June 20, 2023 17:41

oxy force-pushed the rdar95802178 branch from 5efc740 to e0f1201 Compare August 2, 2023 17:51

lorentey reviewed Aug 2, 2023

View reviewed changes

oxy force-pushed the rdar95802178 branch from e0f1201 to 50077c3 Compare August 3, 2023 00:16

lorentey approved these changes Aug 3, 2023

View reviewed changes

oxy force-pushed the rdar95802178 branch from 90a4a9d to 6f19290 Compare August 10, 2023 22:05

glessard approved these changes Aug 10, 2023

View reviewed changes

oxy added 6 commits February 28, 2024 15:23

[stdlib] remove most branches from Array.replaceSubrange

fa50e89

[stdlib] fix Array.replaceSubrange for incorrect with: count

869bbe9

[stdlib] only move/erase/add if required in Array.replaceSubrange

bedda7e

[stdlib] add contiguous fast path in Array.replaceSubrange

c096203

[stdlib] remove unneeded replaceSubrange branch

0590552

[stdlib] remove deinitialize branch (does this do anything?)

f2abb35

oxy force-pushed the rdar95802178 branch from 6f19290 to 229c42e Compare February 28, 2024 20:52

oxy requested a review from a team as a code owner February 28, 2024 20:52

oxy force-pushed the rdar95802178 branch 2 times, most recently from 435a333 to 08586c5 Compare February 29, 2024 02:49

[stdlib] Array.replaceSubrange code cleanup

08586c5

Add an explanation about why UMBP.initialize(fromContentsOf:) can't be used.

glessard approved these changes Mar 1, 2024

View reviewed changes

Catfish-Man merged commit f492087 into apple:main Mar 1, 2024
7 checks passed

glessard mentioned this pull request Mar 11, 2024

Fix SystemString's Collection conformance apple/swift-system#153

Closed

[stdlib] performance optimizations in Array.replaceSubrange #66160

[stdlib] performance optimizations in Array.replaceSubrange #66160

Conversation

oxy commented May 26, 2023

oxy commented May 26, 2023

oxy commented May 26, 2023

oxy commented Jun 5, 2023 • edited

Performance (x86_64): -O

Code size: -O

Performance (x86_64): -Osize

Code size: -Osize

Performance (x86_64): -Onone

Code size: -swiftlibs

oxy commented Jun 5, 2023

oxy commented Jun 5, 2023

Performance (x86_64): -O

Code size: -O

Performance (x86_64): -Osize

Code size: -Osize

Performance (x86_64): -Onone

oxy commented Jun 5, 2023 • edited

Performance (x86_64): -O

Code size: -O

Performance (x86_64): -Osize

Code size: -Osize

Performance (x86_64): -Onone

Catfish-Man Jun 5, 2023

Choose a reason for hiding this comment

Catfish-Man Jun 5, 2023

Choose a reason for hiding this comment

oxy Jun 6, 2023 • edited

Choose a reason for hiding this comment

oxy commented Jun 6, 2023

oxy commented Jun 6, 2023

oxy commented Jun 7, 2023

oxy commented Jun 7, 2023 • edited

Performance (arm64): -O

Code size: -O

Performance (arm64): -Osize

Code size: -Osize

Performance (arm64): -Onone

oxy commented Jun 8, 2023

oxy commented Jun 8, 2023

oxy commented Jun 8, 2023

oxy commented Jun 8, 2023

oxy commented Jun 8, 2023

oxy commented Jun 9, 2023

oxy commented Jun 9, 2023

harlanhaskins commented Jun 18, 2023

oxy commented Aug 2, 2023

oxy commented Aug 2, 2023

Performance (arm64): -O

Code size: -O

Performance (arm64): -Osize

Code size: -Osize

Performance (arm64): -Onone

Code size: -swiftlibs

lorentey Aug 2, 2023

Choose a reason for hiding this comment

lorentey left a comment

Choose a reason for hiding this comment

oxy commented Aug 9, 2023

oxy commented Aug 10, 2023

oxy commented Aug 10, 2023

glessard left a comment

Choose a reason for hiding this comment

oxy commented Aug 14, 2023

oxy commented Aug 18, 2023

Catfish-Man commented Feb 28, 2024

oxy commented Feb 28, 2024

oxy commented Feb 28, 2024 • edited

Catfish-Man commented Feb 29, 2024

Catfish-Man commented Feb 29, 2024

Catfish-Man commented Feb 29, 2024

oxy commented Feb 29, 2024

Performance (x86_64): -O

Code size: -O

Performance (x86_64): -Osize

Code size: -Osize

Performance (x86_64): -Onone

[stdlib] performance optimizations in `Array.replaceSubrange` #66160

[stdlib] performance optimizations in `Array.replaceSubrange` #66160

oxy commented Jun 5, 2023 •

edited

oxy commented Jun 5, 2023 •

edited

oxy Jun 6, 2023 •

edited

oxy commented Jun 7, 2023 •

edited

oxy commented Feb 28, 2024 •

edited