Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

New API for SArray's read_json #2331

Merged
merged 9 commits into from
Sep 25, 2019
Merged

New API for SArray's read_json #2331

merged 9 commits into from
Sep 25, 2019

Conversation

sirahd
Copy link
Collaborator

@sirahd sirahd commented Sep 19, 2019

  • fix SArray.read_json() should be able to read an array  #89
  • update the documented behavior of read_json to allow reading JSON list with homogeneous type.
  • since SFrame's read_json also depends on the modified SArray's read_json, I add assertion to make sure the JSON file read into SFrame is a list of dictionary

@sirahd sirahd requested a review from hoytak September 19, 2019 20:24
hoytak
hoytak suggested changes Sep 20, 2019
View reviewed changes
Copy link
Collaborator

@hoytak hoytak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good. Nice coding. Just a couple of small changes but we're very close.

@sirahd sirahd merged commit 34a3406 into apple:master Sep 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@znation znation znation approved these changes

@hoytak hoytak hoytak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SArray.read_json() should be able to read an array
3 participants
@sirahd @hoytak @znation