Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

Customized s3 error handlings when encountering non-standard errors #3116

Merged
merged 3 commits into from
Apr 30, 2020

Conversation

guihao-liang
Copy link
Collaborator

To avoid collisions (HTTP code 429) when 2 - 3 runners running tests at the same time.

@guihao-liang guihao-liang added this to the 6.2 milestone Apr 13, 2020
@guihao-liang guihao-liang self-assigned this Apr 13, 2020
src/core/storage/fileio/s3_api.cpp Show resolved Hide resolved
src/core/storage/fileio/s3_api.cpp Outdated Show resolved Hide resolved
src/core/storage/fileio/s3_api.cpp Outdated Show resolved Hide resolved
src/core/storage/fileio/s3_api.cpp Outdated Show resolved Hide resolved
@TobyRoseman
Copy link
Collaborator

@guihao-liang - let hold off on merging this until we know how much more reliable the s3 unit tests become with the internal configuration changes.

@guihao-liang
Copy link
Collaborator Author

related to aws/aws-sdk-cpp#1359

@guihao-liang guihao-liang modified the milestones: 6.2, 6.3 Apr 14, 2020
Copy link
Collaborator

@hoytak hoytak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's address the comments to make them clearer for other people to understand the code.

@guihao-liang
Copy link
Collaborator Author

reopen when needed.

Copy link
Collaborator

@TobyRoseman TobyRoseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the title of this PR before you merge, since you're no long using random backoff.

@guihao-liang guihao-liang changed the title random backoff to better avoid collision Customized s3 error handlings when encountering non-standard errors Apr 30, 2020
@guihao-liang guihao-liang merged commit c7cdb86 into apple:master Apr 30, 2020
@guihao-liang guihao-liang deleted the 04-13-random-backoff branch April 30, 2020 02:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants