This repository has been archived by the owner on Dec 21, 2023. It is now read-only.
Fix S3 Region #90
Merged
Fix S3 Region #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S3 Regions are not set in the S3 client. We need to set it to support anything outside of us-east-1
TobyRoseman
reviewed
Dec 14, 2017
| }; | ||
|
|
||
| const std::map<std::string, std::string> AWS_S3_ENDPOINT_TO_REGION { |
There was a problem hiding this comment.
It looks like there are other S3 regions. Do we want to add more here?
http://docs.aws.amazon.com/general/latest/gr/rande.html#s3_region
|
Hmm... The oddity is that the AWS C++ SDK only has a smaller set of regions. |
|
@ylow @TobyRoseman Do we have a decision here - should we take the larger list, from AWS S3 documentation, or the smaller list, from AWS C++ SDK documentation? Do we know whether the larger list includes regions that do actually exist in S3 that we're missing, and whether we need to add them in order for buckets in those regions to work? |
|
Lets add the regions in the AWS C++ SDK list first. We can always add more later. |
znation
approved these changes
Dec 15, 2017
|
Fixes #57. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
S3 Regions are not set in the S3 client. We need to set it to support
anything outside of us-east-1.