Adding feature to check if shell is bash or windows cli. #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Once this check passes, it will use commands specific command to it\'s operating shell. For example, at the command `rm -rf %s` would not work on either terminals, cause -rf is not a valid argument, the command exists for powershell, but not on the normal windows command line. So you would have to change that to `DEL` command isntead, which is supported by both powershell and windows command line.\n\nAnother fix is added is mkdir, though mkdir exists for the commandline, it returns an error when the folder already exists, and the -p argument is not valid for mkdir, and instead creates an actual folder called `-p`. This is why we use `if not exist %s mkdir %s`, cause it checks if that folder exists before creating it. This works on the windows command line, but not on powershell, but if we can, we could also add a check for powershell and use a powershell command instead.
|
Another workaround to these issues, are to change the default shell of OpenSSH to be a bash shell. By installing git, and use the git bash terminal as the default shell. New-ItemProperty -Path "HKLM:\SOFTWARE\OpenSSH" -Name DefaultShell -Value "C:\Users\user\AppData\Local\Programs\Git\bin\bash.exe" -PropertyType String -Forcehttps://docs.microsoft.com/en-us/windows-server/administration/openssh/openssh_server_configuration |
appleboy
force-pushed
the
master
branch
3 times, most recently
from
5658167
to
5672c12
Compare
appleboy
added a commit
that referenced
this pull request
Apr 9, 2023
- Change the `rmcmd` and `mkdircmd` functions to accept an OS parameter - Remove `command_windows.go` file - Modify `removeDestFile` and `Exec` functions to use the OS parameter - Add OS detection logic to `removeAllDestFile` and `Exec` functions - Modify `TestRemoveDestFile` function to use the OS parameter fix #119
|
@ThomasAunvik Thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #111
Closes appleboy/scp-action#39
Possibly Closes: appleboy/scp-action#3
Related Comment: #50 (comment)
Once this check passes, it will use commands specific command to it's operating shell. For example, at the command
rm -rf %swould not work on either terminals, cause -rf is not a valid argument, the command exists for powershell, but not on the normal windows command line. So you would have to change that toDELcommand isntead, which is supported by both powershell and windows command line.Another fix is added is mkdir, though mkdir exists for the commandline, it returns an error when the folder already exists, and the -p argument is not valid for mkdir, and instead creates an actual folder called
-p. This is why we useif not exist %s mkdir %s, cause it checks if that folder exists before creating it. This works on the windows command line, but not on powershell, but if we can, we could also add a check for powershell and use a powershell command instead.