refactor(storage): BoltDB configuration handling #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update `go.etcd.io/bbolt` dependency from v1.3.9 to v1.3.10 - Refactor `InitAppStatus` to pass individual BoltDB and BadgerDB configuration parameters instead of the entire config object - Add `os` package import in `boltdb.go` - Modify `New` function in `boltdb.go` to accept `dbPath` and `bucket` parameters instead of the entire config object - Replace `config` field in `Storage` struct with `dbPath` and `bucket` fields - Update `Init` method in `boltdb.go` to handle empty `dbPath` by setting a default path - Update `setBoltDB` and `getBoltDB` methods to use `bucket` field instead of accessing it from the config - Adjust `boltdb_test.go` to create `boltDB` instance with `dbPath` and `bucket` parameters directly Signed-off-by: appleboy <appleboy.tw@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go.etcd.io/bboltdependency from v1.3.9 to v1.3.10InitAppStatusto pass individual BoltDB and BadgerDB configuration parameters instead of the entire config objectospackage import inboltdb.goNewfunction inboltdb.goto acceptdbPathandbucketparameters instead of the entire config objectconfigfield inStoragestruct withdbPathandbucketfieldsInitmethod inboltdb.goto handle emptydbPathby setting a default pathsetBoltDBandgetBoltDBmethods to usebucketfield instead of accessing it from the configboltdb_test.goto createboltDBinstance withdbPathandbucketparameters directly