Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Play with custom mp4 url #76

Closed
haidang666 opened this issue Aug 13, 2021 · 2 comments
Closed

Play with custom mp4 url #76

haidang666 opened this issue Aug 13, 2021 · 2 comments

Comments

@haidang666
Copy link

I try to set custom prop (as link below) with a mp4 link and channel to be a random text. But it only shows grey modal.

https://www.npmjs.com/package/react-modal-video
@Yoshi0207 Yoshi0207 mentioned this issue Aug 19, 2021
Merged
mkasumi added a commit that referenced this issue Aug 26, 2021
@mkasumi
Merge pull request #77 from Yoshi0207/feature/addCustomProp#76
5d80533 
URLの指定方法の追加#76
@mkasumi mkasumi closed this as completed Aug 26, 2021
@haidang666
Copy link
Author

does it work for now?

@mkasumi
Copy link
Contributor

mkasumi commented Aug 27, 2021

@haidang666
Yes, it is working for now.

Please try to set like this.
https://github.com/appleple/modal-video#mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mkasumi @haidang666