Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove duplicate fields on ShuttleCreateContentBody #284

Merged
merged 1 commit into from
Jun 21, 2022
Merged

chore: remove duplicate fields on ShuttleCreateContentBody #284

merged 1 commit into from
Jun 21, 2022

Conversation

alvin-reyes
Copy link
Contributor

Changes

Simple PR to remove duplicate fields on ShuttleCreateContentBody and reuse ContentCreateBody for it instead

Resolves

#266

@alvin-reyes alvin-reyes self-assigned this Jun 21, 2022
en0ma
en0ma approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@en0ma en0ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alvin-reyes alvin-reyes merged commit 1f30dc6 into master Jun 21, 2022
@alvin-reyes alvin-reyes mentioned this pull request Jun 21, 2022
Closed
@en0ma en0ma deleted the content-body-fix branch June 22, 2022 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@en0ma en0ma en0ma approved these changes

@gmelodie gmelodie Awaiting requested review from gmelodie

Assignees

@alvin-reyes alvin-reyes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alvin-reyes @en0ma