Replace shuttle-proxy with redirects #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Instead of adding it to the main node, we should create a standalone shuttle-proxy that clients can use for their dedicated/self-hosted infra. I'm thinking we should:
|
|
I would agree with that approach if we had to do complicated load balancing, but that's not the case with estuary. It just feels like this is overengineering things, we just need a simple redirect to fix this issue. |
alvin-reyes
previously approved these changes
Jul 14, 2022
|
LGTM on the change. Let's just fix the build and any conflicts. |
anjor
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a discussion with @jlogelin we realized that what
shuttle-proxydid was not very different from what I implemented in #175. I personally think that, at least right now, shuttle-proxy adds an unnecessarily big volume of code, so I just made the main node do what shuttle-proxy did:When a client hits
/content/addor/content/add-carand--disable-content-addingis set on the main node, it fetches available endpoints (other shuttles) and makes the call to them.Obs: this PR also fixes the biggest issue with #175: users don't need to worry about redirecting now, since the main node just does everything for them transparently.