-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.gcode Generated by Prusa Slicer Not Recognized #23
Comments
@nverdonk can you attach the file here so I can try it on my computer with the current dev version? |
@mikecentola Yes, here is a file to play around with. I just sliced it now and confirmed the same issue is occurring. Had to ZIP it as GitHub won't allow native upload of .gcode |
@nverdonk I'm on it! |
@nverdonk yup @belkid is correct. I got the same error |
@nverdonk Could be because the file is so large. Let me do some investigating on that side as well. |
@mikecentola @BelKed Thank you for such quick responses and help! @mikecentola I believe the file size is the issue with the tree. I deleted pretty much the whole file (~550,000 lines to 374 lines) and the tree loads correctly now. The tree would be so cumbersome for a file of that size anyway; don't think this will ruin anyone's workflow :), just wanted to make sure it wasn't a bug. |
No worries. I wonder if I should add a detection for large files to not even try if it's over a certain size. |
I think adding note or warning along the lines of This file exceeds maximum readable file size of _____ MB. VS Code might disable highlighting and GCODE tree will not generate would help catch people in my situation in the future. |
@nverdonk yeah for sure. I'll see if I can find somewhere to add it. I'm working on the hover code right now. |
I added a warning popup for anything over 10K lines when autoRefresh is enabled. |
I think that's a great addition and will save people a lot of headache in the future! I'll close out the issue for now and we can reopen if needed. |
This issue has been automatically locked since there has not been any recent activity after it was close. Please open a new issue for related topics. |
Describe the bug
G-Code files produced by PrusaSlicer are not recognized or highlighted by extension. They are .gcode file extensions.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Expect the file type to be recognized and highlighted properly. VS code seems to recognize that it is a gcode language but extension does not (see screenshot below),
Screenshots
Environment / Version:
Additional context
I might be missing a step in the process here as the extension is working properly if I make a blank .gcode file and type some commands in.
I have also copied all the text from the PrusaSlicer generated file and pasted into the user-made file and correct highlighting occurs
Let me know if this should be moved, tagged, or deleted.
The text was updated successfully, but these errors were encountered: