Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mode parameters should be available also with explicit flag names #84

Closed
afronski opened this issue Feb 27, 2018 · 1 comment
Closed

Comments

@afronski
Copy link
Contributor

I would like to open discussion here about the usability of our CLI modes.

Currently, most of the modes uses implicit order of parameters, e.g.,

perun convert A.json B.yaml
perun convert A.yaml B.json --pretty-print

That's good. However, I would love to have it available also under explicit parameter names:

perun convert A.json B.yaml
perun convert --from=A.json --to=B.yaml

perun convert A.yaml B.json --pretty-print
perun convert --from=A.yaml --to=B.json --pretty-print

I know that will complicate the implementation, but maybe advantages are more significant than drawbacks.

@afronski afronski added this to the Cumulus - 2.0 milestone Feb 27, 2018
@afronski afronski added this to BACKLOG in Perun via automation Feb 27, 2018
@maxiwoj maxiwoj moved this from BACKLOG to IN PROGRESS in Perun Feb 27, 2018
@maxiwoj maxiwoj self-assigned this Feb 27, 2018
@maxiwoj
Copy link
Contributor

maxiwoj commented Feb 28, 2018

AFAIK it will significantly complicate the code and the usage of the tool - the kingpin cli arguments parser is not designed for this, but I'll create a quick PR for everyone to see.

maxiwoj pushed a commit that referenced this issue Feb 28, 2018
Added support for specifying mode arguments via flags
afronski added a commit that referenced this issue Mar 1, 2018
@afronski afronski closed this as completed Mar 1, 2018
Perun automation moved this from IN PROGRESS to READY TO RELEASE Mar 1, 2018
@afronski afronski moved this from READY TO RELEASE to REVIEWED in Perun Mar 1, 2018
maxiwoj pushed a commit that referenced this issue Mar 8, 2018
Added support for specifying mode arguments via flags
jlampar pushed a commit that referenced this issue Mar 9, 2018
Added support for specifying mode arguments via flags
jlampar pushed a commit that referenced this issue Mar 9, 2018
Added support for specifying mode arguments via flags
piwowarc pushed a commit that referenced this issue Jun 25, 2018
Added support for specifying mode arguments via flags
piwowarc pushed a commit that referenced this issue Jun 25, 2018
Added support for specifying mode arguments via flags
@maxiwoj maxiwoj moved this from REVIEWED to RELEASED in Perun Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Perun
  
RELEASED
Development

No branches or pull requests

2 participants