-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add color palette #48 #49
Conversation
@color-gray-10: fade(#000, 10%); | ||
@color-gray-25: fade(#000, 25%); | ||
@color-gray-30: fade(#000, 30%); | ||
@color-borderColor: @color-gray; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when would you use @color-borderColor
verses @color-default-borderColor
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
default
is related to the default button coloring. I would think that we would use @color-borderColor
anytime we need to define a border we would set the color using this variable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I see the distinction either.
@color-white: #fff; | ||
@color-black: black; | ||
|
||
@color-gray-5: fade(@color-black, 5%); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I vote that we use only one set of grays. It's weird to be using two sets.
I think it makes more sense to move nearly all the logic in the example in to the |
@@ -8,11 +8,7 @@ | |||
display: inline-block; | |||
outline: none; | |||
border: 1px solid @color-default-borderColor; | |||
border-radius: @size-button-borderRadius; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean to remove button styles?
@@ -77,3 +78,222 @@ html { | |||
} | |||
} | |||
} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should these styles perhaps live in their own less file at src/docs/containers/colors.less
maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably, I've just been throwing everything in index until it grows too big.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed for this PR I think though
Standardizing colors