Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 Multipart Uploads #117

Merged
merged 1 commit into from Oct 24, 2012
Merged

S3 Multipart Uploads #117

merged 1 commit into from Oct 24, 2012

Conversation

@marios
Copy link
Contributor

@marios marios commented Oct 24, 2012

Hi - this commit adds calls for the S3 multipart upload API - as described at Multipart Upload Overview

def initiate_multipart(bucket, key, headers={})
API DOCS

def upload_part(bucket, key, uploadId, partNumber, data, headers={})
API DOCS

def complete_multipart(bucket, key, uploadId, manifest_hash, headers={})
API DOCS

thanks for your consideration,

marios

@marios
Copy link
Contributor Author

@marios marios commented Oct 24, 2012

... we need this functionality in the aws rubygem as part of adding a 'multipart' or 'segmented blob' upload to the Deltacloud blob storage API - described in part here - ongoing.

@treeder
Copy link
Member

@treeder treeder commented Oct 24, 2012

Looks good. Any tests by any chance?

treeder pushed a commit that referenced this pull request Oct 24, 2012
@treeder treeder merged commit 3cec694 into appoxy:master Oct 24, 2012
@marios
Copy link
Contributor Author

@marios marios commented Oct 25, 2012

Hi! first off thanks for merging this so quickly. Sure - I'll put get some tests out asap and open a new pull request for you.

In the meantime, after more testing today I noticed an issue with one regex used to extract the 'uploadId' parameter in the pull request you merged. Basically, the Id can include characters like '.' e.g. this is a valid uploadId I got today:

"pCz.6i8XVQHubk9RxTgufJPjXFXp1O6LfaXgM3LBCw82GcO5Eb8WfsUGNuj.jqR3CS5Y1nh8MNU55fB5mdw.PkBO1J3sh5bXgj6.hcppoi7V_73PluHJDt8p1bQqV1we"

It's a minor edit - I have a commit on my branch - would you like a pull request or you prefer to just apply it as it's so minor?

thanks! marios

@treeder
Copy link
Member

@treeder treeder commented Oct 25, 2012

Pull request would be great, thanks.

On Thu, Oct 25, 2012 at 6:00 AM, marios notifications@github.com wrote:

Hi! first off thanks for merging this so quickly. Sure - I'll put get some
tests out asap and open a new pull request for you.

In the meantime, after more testing today I noticed an issue with one
regex used to extract the 'uploadId' parameter in the pull request you
merged. Basically, the Id can include characters like '.' e.g. this is a
valid uploadId I got today:

"pCz.6i8XVQHubk9RxTgufJPjXFXp1O6LfaXgM3LBCw82GcO5Eb8WfsUGNuj.jqR3CS5Y1nh8MNU55fB5mdw.PkBO1J3sh5bXgj6.hcppoi7V_73PluHJDt8p1bQqV1we"

It's a minor edit - I have a commit on my branchhttps://github.com/marios/aws/commit/1de03c99360021b8523d3cc5b315fde768100b42- would you like a pull request or you prefer to just apply it as it's so
minor?

thanks! marios


Reply to this email directly or view it on GitHubhttps://github.com//pull/117#issuecomment-9776506.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants