Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for Eucalyptus cloud #56

Merged
1 commit merged into from
Feb 25, 2011
Merged

support for Eucalyptus cloud #56

1 commit merged into from
Feb 25, 2011

Conversation

sangmin
Copy link

@sangmin sangmin commented Feb 23, 2011

Greetings,

I'm the engineer working at Eucalyptus systems.
In this patch, two changes were made to support Eucalyptus-backend in addition to EC2/S3.

  • Naming a bucket in virtual hosted-style request (e.g., http://yourbucket.s3.amazonaws.com/yourobject) may have an issue with Eucalyptus. Because naming a bucket through URL path (e.g., http://s3.amazonaws.com/yourbucket/yourobject) always work with S3 and Eucalyptus, we changed the code that way.
  • EC2 CreateVolume has an optional parameter 'SnapshotId', which appears on HTTP request only when it is set by user. Sending it with empty snapshot id (SnapshotId='') has an issue with Eucalyptus backend. So the patch removes the parameter when it's not set.

Both changes were tested against EC2/S3 and passed.
Thanks!

# with '#' will be ignored, and an empty message aborts the commit.
#
# Committer: Sang-Min Park <sang-min@ubuntu.(none)>
#
# On branch master
# Changes to be committed:
#   (use "git reset HEAD <file>..." to unstage)
#
#	modified:   lib/ec2/ec2.rb
#	modified:   lib/s3/s3_interface.rb
#
@treeder
Copy link
Member

treeder commented Feb 24, 2011

Great, thanks! will review and pull shortly.

@treeder
Copy link
Member

treeder commented Feb 25, 2011

Merged and released, 2.4.3

@sangmin
Copy link
Author

sangmin commented Feb 25, 2011

great. that was really fast. thanks!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants