added support for custom tags to broken QEc2DescribeSnapshotParser #77
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parser code in ec2.rb, line 2022:
2021 def tagstart(name, attributes)
=> 2022 @snapshot = {} if name == 'item'
2023 end
was failing on input like the following:
b9cde6c8-29d1-4f5d-bd1b-3c8c1565535c
snap-121ec67e
... tags removed for clarity...
c5 snap after April outage
rotation_level
daily 1
The problem is that is being used in two different contexts,
and the Parser class is not keeping track of state. I would expect to
see that custom tags added to snapshots would appear in the resultant
snapshot hash. Instead, when they are encountered they wipe out all
of the hash attributes parsed so far for the snapshot.
This patch fixes the parser, custom tags like the one above:
rotation_level
daily 1
will appear in the snapshot hash as:
{ :aws_tag_rotation_level => 'daily 1' }