Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hi please consider this minor commit - necessary for security groups #79

Closed
wants to merge 1 commit into from
Closed

Conversation

marios
Copy link
Contributor

@marios marios commented May 2, 2011

Fix minor issue in describe_security_groups - missing the protocol and port ranges when interpreting result of QEc2DescribeSecurityGroupsParser (though parser is getting this correctly).

Slightly related issue that may be of interest/you may know of + can help with:

the API docs @ http://docs.amazonwebservices.com/AWSEC2/latest/APIReference/index.html?ApiReference-ItemType-SecurityGroupItemType.html and also http://docs.amazonwebservices.com/AWSEC2/latest/APIReference/index.html?ApiReference-query-DescribeSecurityGroups.html show that each security group also has a 'groupId' returned in the response. I thought this was an issue with the QEc2DescribeSecurityGroupsParser but its not (though the parser is not trying to get this info currently). It seems the response from ec2 doesn't include this information - I've posted to https://forums.aws.amazon.com/thread.jspa?threadID=66553&tstart=0

all the best, marios

…d port ranges when interpreting result of QEc2DescribeSecurityGroupsParser (though parser is getting this correctly)
@marios
Copy link
Contributor Author

marios commented May 5, 2011

Please ignore this commit - I've since found more issues with the security groups parser. I'll be sending a new pull request with those changes and explanation.

thanks, marios

@marios marios closed this May 5, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant