Hi please consider this minor commit - necessary for security groups #79
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix minor issue in describe_security_groups - missing the protocol and port ranges when interpreting result of QEc2DescribeSecurityGroupsParser (though parser is getting this correctly).
Slightly related issue that may be of interest/you may know of + can help with:
the API docs @ http://docs.amazonwebservices.com/AWSEC2/latest/APIReference/index.html?ApiReference-ItemType-SecurityGroupItemType.html and also http://docs.amazonwebservices.com/AWSEC2/latest/APIReference/index.html?ApiReference-query-DescribeSecurityGroups.html show that each security group also has a 'groupId' returned in the response. I thought this was an issue with the QEc2DescribeSecurityGroupsParser but its not (though the parser is not trying to get this info currently). It seems the response from ec2 doesn't include this information - I've posted to https://forums.aws.amazon.com/thread.jspa?threadID=66553&tstart=0
all the best, marios