[updated]: 1) Update Authorize and Revoke security group permissions and 2) Minor issue - compatibility with ruby 1.8.6 and 3) Minor typo in aws.gemspec (missing lib/awsbase/support.rb) #89
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to maintain compatibility with Ruby 1.8.6 (use "string".to_a.each rather that "string".each_char)
Don't know if compatibility with ruby 1.8.6 is something you want to maintain - ran into this issue so thought I'd let you know.
The second commit reworks the Authorize and Revoke security groups ingress code. I believe the earlier implementations were based on http://docs.amazonwebservices.com/AWSEC2/2009-07-15/APIReference/ApiReference-query-AuthorizeSecurityGroupIngress.html . In the latest version of API, you can specify a number of IP addresses, or groups, or mix of both, for which the specified rule will apply. Also, in the earlier API you couldn't specify 'from_port' 'to_port' 'protocol' for groups whereas now you can.
I implemented authorize and revoke as one method 'manage_security_group_ingress' (with an action parameter to specify which), since the only difference between them is the 'action' - if you prefer you should seperate them into seperate methods.
Finally the last commit is a very minor fix to gemspec - it looks like a file was removed along the way (lib/awsbase/support.rb) but the gemspec is still looking for this so there's an error if you want to build the gem by hand,
Thanks for considering these commits,
all the best, marios