Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We've been using my version of require_relative (overwriting yours via config/preinitializer.rb) for a while now with no problems. #98

Merged
merged 1 commit into from
Mar 2, 2012

Conversation

ctm
Copy link
Contributor

@ctm ctm commented Aug 1, 2011

I've tested this version in our own code and it seems to work fine.

I've tested this version in our own code and it seems to work fine.
@lovitt
Copy link

lovitt commented Sep 23, 2011

I believe ctm is fixing the numerous already initialized constant warnings that appear in some installs:

$ script/console 
Loading development environment (Rails 2.3.8)
/Users/mlovitt/.rvm/gems/ree-1.8.7-2010.02@sbn/gems/aws-2.5.6/lib/ses/../awsbase/utils.rb:105: warning: already initialized constant HEX
/Users/mlovitt/.rvm/gems/ree-1.8.7-2010.02@sbn/gems/aws-2.5.6/lib/ses/../awsbase/utils.rb:107: warning: already initialized constant TO_REMEMBER
/Users/mlovitt/.rvm/gems/ree-1.8.7-2010.02@sbn/gems/aws-2.5.6/lib/ses/../awsbase/utils.rb:108: warning: already initialized constant ASCII
/Users/mlovitt/.rvm/gems/ree-1.8.7-2010.02@sbn/gems/aws-2.5.6/lib/ses/../awsbase/errors.rb:128: warning: already initialized constant DEFAULT_CLOSE_ON_4XX_PROBABILITY
/Users/mlovitt/.rvm/gems/ree-1.8.7-2010.02@sbn/gems/aws-2.5.6/lib/ses/../awsbase/parsers.rb:47: warning: already initialized constant DEFAULT_XML_LIBRARY
/Users/mlovitt/.rvm/gems/ree-1.8.7-2010.02@sbn/gems/aws-2.5.6/lib/ses/../awsbase/awsbase.rb:66: warning: already initialized constant AMAZON_PROBLEMS
/Users/mlovitt/.rvm/gems/ree-1.8.7-2010.02@sbn/gems/aws-2.5.6/lib/ses/../awsbase/awsbase.rb:86: warning: already initialized constant DEFAULT_SIGNATURE_VERSION
ree-1.8.7-2010.02 :001 >

This patch fixes it for me, too.

@os0x
Copy link

os0x commented Nov 22, 2011

+1

treeder added a commit that referenced this pull request Mar 2, 2012
We've been using my version of require_relative (overwriting yours via config/preinitializer.rb) for a while now with no problems.
@treeder treeder merged commit ebd9920 into appoxy:master Mar 2, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants