Skip to content
This repository has been archived by the owner on Jun 29, 2020. It is now read-only.

Add "Architectures" to "generate-stackbrew-library.sh" output #89

Merged
merged 1 commit into from
May 21, 2018

Conversation

tianon
Copy link
Contributor

@tianon tianon commented May 21, 2018

Closes #68

For repos under https://github.com/docker-library, we generally invoke bashbrew from within generate-stackbrew-library.sh to get the Architectures list of the image we're FROM directly, but I wasn't sure if you wanted to add that additional dependency for running the script here, so I wrote a quick one-liner to do the work as a one-off into files that get checked in (which also makes it easier to munge them if it turns out one of them fails to build or doesn't run properly etc and needs to be excluded).

As always, happy to adjust, rebase, amend, etc. I could also set up Travis to test i386, if that's deemed useful (memcached has an example of that: https://github.com/docker-library/memcached/blob/5a09fc033d8e239ebecf1edb20b7f921d51de591/.travis.yml).

@md5 md5 merged commit 8069b7a into appropriate:master May 21, 2018
@tianon tianon deleted the arches branch May 21, 2018 23:22
@tianon
Copy link
Contributor Author

tianon commented May 21, 2018

🎉 Want me to make the PR over to https://github.com/docker-library/official-images for you, or would you rather take that yourself?

@md5
Copy link
Member

md5 commented May 21, 2018 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants