Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django model utils issue on devstack #50

Closed
OmarIthawi opened this issue Sep 25, 2020 · 3 comments · Fixed by appsembler/django-tiers#20
Closed

Django model utils issue on devstack #50

OmarIthawi opened this issue Sep 25, 2020 · 3 comments · Fixed by appsembler/django-tiers#20

Comments

@OmarIthawi
Copy link

Problem: Devstack breaks and throws a TypeError error on the LMS.

django-tiers 0.2.1 requires django-model-utils<=2.3.1, but you'll have django-model-utils 3.2.0 which is incompatible.

See the LMS pages show TypeError exception error instructions.

@OmarIthawi
Copy link
Author

Now pip gives me this on AMC pip install -r requirements/base.txt.

ERROR: After October 2020 you may experience errors when installing or updating packages. This is because pip will change the way that it resolves dependency conflicts.
We recommend you use --use-feature=2020-resolver to test your packages with the new resolver before it becomes the default.
django-tiers 0.2.1 requires django-model-utils<=2.3.1, but you'll have django-model-utils 3.2.0 which is incompatible. 

@thraxil
Copy link

thraxil commented Sep 25, 2020

I think the django-models-utils<=2.3.1 constraint in django-tiers isn't necessary. It looks like it was added in the initial commit: https://github.com/appsembler/django-tiers/blame/master/setup.py#L26 and has never been updated. django-tiers only uses the TimeStampedModel from django-model-utils and that shouldn't require any kind of version restriction. I can only assume that the contstraint was originally placed as boilerplate.

@OmarIthawi
Copy link
Author

Thanks @thraxil! I'll just remove the constraint then, it should fix this devstack issue.

OmarIthawi added a commit to appsembler/django-tiers that referenced this issue Sep 25, 2020
Remove restrictions for django-model-utils and python-dateutil

Fixes appsembler/devstack#50
OmarIthawi added a commit to appsembler/django-tiers that referenced this issue Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants