Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct version number? #19

Closed
afragen opened this issue Oct 5, 2022 · 2 comments
Closed

Correct version number? #19

afragen opened this issue Oct 5, 2022 · 2 comments

Comments

@afragen
Copy link
Contributor

afragen commented Oct 5, 2022

I noticed the current release is v1.2.1. Is the following variable supposed to reflect that or is it specific to class Client?

client/src/Client.php

Line 16 in d110c53

public $version = '1.2.0';

@tareq1988
Copy link
Member

The variable is supposed to reflect the release, not the Client class. Seems like it was missed.

CC: @bdmehedi

@bdmehedi
Copy link
Contributor

Yes, it was missed. We will fix this in the next release.
And it doesn't reflect the Client class

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tareq1988 @afragen @bdmehedi