-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Epic]:Improve the pagination setup in tables #13180
Comments
Assuming server-side pagination users to be the impacted ones Stats
|
Server side sort conversation https://discord.com/channels/725602949748752515/760761686549463060/968616214312149043 |
@sbalaji1192 to review |
@dilippitchika |
@sbalaji1192 for the dev to write a query on whether the app viewer has clicked on next or previous, we either need lastPageNo or pageDirection to be saved. They will be used in the following manner
|
@dilippitchika Understood the pageDirection property. But bit unsure of lastPageNo, how we will compute the lastPageNo. is it the last the page that an user can go up to? |
Oh maybe the term is wrong, what i was referring to is the pageNo that the user was previously on so that they can compare this with the page number they are currently on. |
@dilippitchika When infinite scrolling becomes possible, does this also mean that when users use the Download button, it will download the entire data as opposed to how it is today when using serverside pagination? |
@danciaclara that is a setting which we will expose for devs to configure since we don't know if we can do it ourselves. Better to give them the power. |
ok. The reason I asked was due to the conversation here - https://discord.com/channels/725602949748752515/1042382821265772564/1042382821265772564 Mostly around whether the download action be slow for larger tables if the devs have to configure the Download for the entire table data. |
@danciaclara the problem here is related to conversion as user pointed out, i believe the best way to handle it simply use a js lib which converts json to xls. Once the js libs feature is live. The performance will be impacted based on the data user has and the computation we have to do on client, but this is not a table widget problem it's a platform problem on handling large data. |
Objective
Improve pagination in table to support the following
Give devs a clear option to choose scrolling or pagination
Today it’s hard to enable only scrolling on table and no pagination. We want to make this easy for the user to select if they want to show all data on scroll or on pagination
Expose details for cursor based pagination
Today we can support cursor based pagination, but to support it lastPageNo or pageDirection is needed so that the dev knows whether the user has clicked next or previous.
Once we understand the amount of references for lastPageNo or pageDirection in queries, we can then implement full fledged cursor driven pagination
Extend this to support infinite scroll
Milestone 1
Add support for infinite scroll without exposing any new properties
The text was updated successfully, but these errors were encountered: