Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]: create test case for dragging building block to canvas with reflow #34146

Closed
jacquesikot opened this issue Jun 10, 2024 · 0 comments · Fixed by #34215
Closed

[Task]: create test case for dragging building block to canvas with reflow #34146

jacquesikot opened this issue Jun 10, 2024 · 0 comments · Fixed by #34215
Assignees
@jacquesikot
Labels
Accelerators Product Issues related to app building accelerators Building blocks Building blocks on cavas, on templates listing or drag and drop of building blocks. Task A simple Todo Templates Product Issues related to Templates Widgets & Accelerators Pod Issues related to widgets & Accelerators

Comments

@jacquesikot
Copy link
Contributor

SubTasks

Adds test for this PR - #34143
@jacquesikot jacquesikot added Task A simple Todo Templates Building blocks Building blocks on cavas, on templates listing or drag and drop of building blocks. labels Jun 10, 2024
@jacquesikot jacquesikot self-assigned this Jun 10, 2024
@github-actions github-actions bot added the Templates Product Issues related to Templates label Jun 10, 2024
@jacquesikot jacquesikot mentioned this issue Jun 12, 2024
Merged
2 tasks
jacquesikot added a commit that referenced this issue Jun 13, 2024
@jacquesikot
feat: add tests for AddAndMove and AddBuildingBlocks to canvas (#34215)
dbffbb8 
## Description
Ad unit tests for adding and moving building blocks saga.


Fixes #34146

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9494392536>
> Commit: c6b9b1b
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9494392536&attempt=1"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->






## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Tests**
- Added comprehensive tests for adding and moving building blocks on the
canvas.
  - Updated import paths for consistency in test files.
- Introduced new test suites for sagas handling building block
operations.

- **New Fixtures**
- Added mock data and constants for testing building block
functionalities.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@Nikhil-Nandagopal Nikhil-Nandagopal added the Widgets & Accelerators Pod Issues related to widgets & Accelerators label Aug 6, 2024
@github-actions github-actions bot added the Widgets Product This label groups issues related to widgets label Aug 6, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added Accelerators Product Issues related to app building accelerators and removed Widgets Product This label groups issues related to widgets labels Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacquesikot jacquesikot

Labels
Accelerators Product Issues related to app building accelerators Building blocks Building blocks on cavas, on templates listing or drag and drop of building blocks. Task A simple Todo Templates Product Issues related to Templates Widgets & Accelerators Pod Issues related to widgets & Accelerators
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add tests for AddAndMove and AddBuildingBlocks to canvas appsmithorg/appsmith
2 participants
@Nikhil-Nandagopal @jacquesikot