Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] On Reseting the multi-select dropdown of a form widget the default value does not get selected #4230

Closed
prapullac opened this issue Apr 30, 2021 · 2 comments · Fixed by #5228
Assignees
Labels
Bug Something isn't working High This issue blocks a user from building or impacts a lot of users Needs Triaging Needs attention from maintainers to triage Release Select Widget Select or dropdown widget Verified When issue is retested post its fixed Widgets Product This label groups issues related to widgets

Comments

@prapullac
Copy link
Contributor

prapullac commented Apr 30, 2021

Steps to reproduce:

  1. Drag a dropdown
  2. Make it multi select
  3. Select a default value
  4. Select 3 values
  5. Reset the form
  6. The dropdown get reset
    and observe

Observation:
after reset the default value is not displayed to user

Expectation:
Default value must be displayed to user

Screen.Recording.2021-04-30.at.11.21.00.AM.mov
@prapullac prapullac added Bug Something isn't working Low An issue that is neither critical nor breaks a user flow Release Needs Triaging Needs attention from maintainers to triage labels Apr 30, 2021
@somangshu somangshu added Select Widget Select or dropdown widget High This issue blocks a user from building or impacts a lot of users and removed Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage labels Apr 30, 2021
@github-actions github-actions bot added Widgets Product This label groups issues related to widgets UI Building Pod labels Apr 30, 2021
@somangshu
Copy link
Contributor

related to #3339. Resolving this separately

@riodeuno
Copy link
Contributor

Fixed in #5228

@somangshu somangshu mentioned this issue Jun 28, 2021
7 tasks
@close-label close-label bot added the QA Needs QA attention label Aug 3, 2021
@YogeshJayaseelan YogeshJayaseelan added the Verified When issue is retested post its fixed label Aug 4, 2021
@vivekverma2312 vivekverma2312 removed the QA Needs QA attention label Sep 6, 2021
pedro-santos-rodrigues pushed a commit that referenced this issue Jun 20, 2024
## Description
Update in designs of workflow trigger config screen. The updated designs
can be found here:
https://www.figma.com/design/mRir7UsZ0U7usSb0asFU0h/Workflow-UI-Handoff?node-id=829-21522&t=iHC5JIs5it1NGZd1-0

Note: Tooltips are not includes in this implementation, might be picked
in upcoming iterations.


Fixes [#33022](#33022)

## Automation

/ok-to-test tags="@tag.Workflows"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith-ee/actions/runs/9171718156>
> Commit: eec18b46168951b87a8af04eaf2af5a2a740c055
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9171718156&attempt=2"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->





## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Updated labels and descriptions for webhook triggers and workflow
actions.
	- Added new constants related to webhook triggers and workflow actions.
- Added `data-testid` attributes for testing in the
`RegenerateTokenModal` component.
	- Introduced test cases for the `TriggerWorkflowSettings` component.
- Modified constants, URL generation logic, and button functionalities
in `TriggerWorkflowSettings.tsx`.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working High This issue blocks a user from building or impacts a lot of users Needs Triaging Needs attention from maintainers to triage Release Select Widget Select or dropdown widget Verified When issue is retested post its fixed Widgets Product This label groups issues related to widgets
Projects
None yet
9 participants