Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated help text and client tests #32521

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

NilanshBansal
Copy link
Contributor

@NilanshBansal NilanshBansal commented Apr 9, 2024

Description

This PR updates the help text for twilio message SID for client side tests.
This fix also needs a cloud services database updation as the data on the UI is received from cs.

Fixes #25056

Automation

/ok-to-test tags="@tag.Datasource"

🔍 Cypress test results

Important

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8613830151
Commit: 6f8450c97e501dbfecfd328079bf21b911234c13
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

@github-actions github-actions bot added Query & JS Pod Issues related to the query & JS Pod Bug Something isn't working Integrations Product Issues related to a specific integration Low An issue that is neither critical nor breaks a user flow Low effort Takes 1-2 days Needs Triaging Needs attention from maintainers to triage Papercut a trivially fixable usability bug Production Twilio Issues related to Twilio integration labels Apr 9, 2024
@NilanshBansal NilanshBansal self-assigned this Apr 9, 2024
Copy link
Contributor

coderabbitai bot commented Apr 9, 2024

Walkthrough

Walkthrough

The modifications in the code primarily focus on clarifying the description of the Message SID field within the Twilio integration components. This change is aimed at correcting the misconception that the field refers to the messaging service's SID, instead emphasizing that it actually pertains to the message's SID. This adjustment enhances the accuracy of the help text, ensuring users are better guided in their interactions with message-related queries.

Changes

File Path Change Summary
.../PartialImportExport/PartialExportModal/unitTestUtils.ts Updated subtitle field for Message SID input to specify it refers to the message SID.
MockPluginsState.ts Same as above for consistency across components.

Assessment against linked issues

Objective Addressed Explanation
Clarify that the Message SID field refers to the message's SID, not the messaging service's SID (#25056)

Possibly related issues

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@NilanshBansal NilanshBansal added the ok-to-test Required label for CI label Apr 9, 2024
@NilanshBansal
Copy link
Contributor Author

The cloud services database needs to be updated to show the message in the UI.
The help text comes from plugins collection in cloud services.
SCR-20240409-qqm

@NilanshBansal NilanshBansal merged commit 7f5e831 into release Apr 10, 2024
46 of 47 checks passed
@NilanshBansal NilanshBansal deleted the fix/issue-25056/twilio-help-text branch April 10, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Integrations Product Issues related to a specific integration Low effort Takes 1-2 days Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage ok-to-test Required label for CI Papercut a trivially fixable usability bug Production Query & JS Pod Issues related to the query & JS Pod Twilio Issues related to Twilio integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Twilio help text wrongly indicates service SID instead of message SID
2 participants