fix: button group spec #33234

jsartisan · 2024-05-07T09:58:18Z

Fixes the button group failing spec

/ok-to-test tags="@tag.Button"

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8985593689
Commit: 667b7d1
Cypress dashboard url: Click here!

coderabbitai · 2024-05-07T09:58:25Z

Walkthrough

The changes primarily focus on standardizing button label handling across various widgets and tests in the codebase. This includes updating default labels, modifying test scripts to use dynamic labels, and ensuring that UI components reflect these changes consistently.

Changes

Files	Change Summary
`.../ButtonGroup2_spec.ts`, `.../messages.ts`, `.../ButtonListControl.tsx`, `.../defaultsConfig.ts`, `.../contentConfig.ts`, `.../menuItemsConfig.ts`	Updated button label handling using dynamic constants and modified test scripts accordingly.
`.../messages.ts`	Added new constant for default button label.

Possibly related issues

[Bug]: Button group widget's buttons have the most confusing naming convention on the platform #15987: The changes align with the objective to standardize and rectify button naming conventions as this PR introduces a consistent approach to button labels across widgets.
[Task]: Fix cypress test suite failures caused by PR #29794 #30378: This PR could potentially resolve test suite failures related to button label changes, as it includes updates to Cypress tests to accommodate new button label logic.

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between af27a00 and 667b7d1.

Files selected for processing (1)

app/client/src/ce/constants/messages.ts (1 hunks)

Files skipped from review as they are similar to previous changes (1)

app/client/src/ce/constants/messages.ts

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

jsartisan · 2024-05-07T10:49:42Z

/ci-test-limit

github-actions · 2024-05-07T10:50:12Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8984051822.
Cypress dashboard
PR: #33234.

mohanarpit · 2024-05-07T10:50:27Z

app/client/cypress/e2e/Regression/ClientSide/Widgets/Button/ButtonGroup2_spec.ts

@@ -163,7 +163,7 @@ describe(
      agHelper.ClickButton("Close");
      EditorNavigation.SelectEntityByName("ButtonGroup1", EntityType.Widget);
      agHelper.GetNClick(buttongroupwidgetlocators.buttonSettingInPropPane, 0);
-      propPane.EnterJSContext("onClick", "{{showModal(Modal1.name)}}");
+      propPane.EnterJSContext("onClick", "{{showModal('Modal1')}}");


@jsartisan Not sure why we are changing this. This was an enhancement done by Aman recently where we can access Modals by using the property Modal.name instead of Modal1. If this feature isn't working in Cypress test case, it's a regression & we should resolve this problem in the product rather than in the Cypress test.

CC: @AmanAgarwal041

oh sorry, I didnt take latest pull for release before checking out the new branch. Let me fix this.

mohanarpit · 2024-05-07T10:55:41Z

app/client/cypress/e2e/Regression/ClientSide/Widgets/Button/ButtonGroup2_spec.ts

+      agHelper.TypeText("//*[ @value='Do Something']", " New Button");
+      agHelper.AssertContains("Do Something New Button");


@jsartisan Shouldn't this be "Do something"? Across the entire product, we follow sentence casing. Should the default text on the button follow the same conventions?

Btw, is it possible for us to use a constant variable in the product & Cypress test to avoid such a failure in the future?

The text was suggested by Taras. I'll check with him if we need to change the casing.

Btw, is it possible for us to use a constant variable in the product & Cypress test to avoid such a failure in the future?

Let me check on this.

Added the label in the messages file and used it everywhere. Thanks for the suggestion.

jsartisan · 2024-05-07T11:01:32Z

/ci-test-limit

github-actions · 2024-05-07T11:02:00Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8984186202.
Cypress dashboard
PR: #33234.

coderabbitai

Actionable comments posted: 0

Out of diff range and nitpick comments (1)

app/client/cypress/limited-tests.txt (1)

1-1: Minor grammatical correction: consider changing "give the spec names in below format" to "give the spec names in the format below".

github-actions · 2024-05-07T11:13:09Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8984051822.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

jsartisan · 2024-05-07T11:30:54Z

/ci-test-limit

github-actions · 2024-05-07T11:31:23Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8984565365.
Cypress dashboard
PR: #33234.

github-actions · 2024-05-07T11:54:21Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8984565365.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

jsartisan · 2024-05-07T12:10:20Z

/ci-test-limit

github-actions · 2024-05-07T12:10:57Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8985063634.
Cypress dashboard
PR: #33234.

github-actions · 2024-05-07T12:35:01Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8985063634.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

ankitakinger · 2024-05-07T12:38:50Z

app/client/cypress/limited-tests.txt

@@ -1,5 +1,6 @@
 # To run only limited tests - give the spec names in below format:
-cypress/e2e/Regression/ClientSide/Templates/Fork_Template_spec.js
+#cypress/e2e/Regression/ClientSide/Templates/Fork_Template_spec.js


can we revert this file changes?

jsartisan changed the title ~~fix:button group spec~~ fix: button group spec May 7, 2024

github-actions bot added the Bug Something isn't working label May 7, 2024

jsartisan added the ok-to-test Required label for CI label May 7, 2024

jsartisan requested a review from ankitakinger May 7, 2024 10:41

ankitakinger previously approved these changes May 7, 2024

View reviewed changes

jsartisan dismissed ankitakinger’s stale review via b0d9726 May 7, 2024 10:49

mohanarpit reviewed May 7, 2024

View reviewed changes

jsartisan force-pushed the fix/failing-button-group branch from b0d9726 to 26771a5 Compare May 7, 2024 10:58

coderabbitai bot reviewed May 7, 2024

View reviewed changes

jsartisan requested review from a team and marks0351 and removed request for a team May 7, 2024 11:17

Pawan Kumar added 3 commits May 7, 2024 16:48

fix the button group test

e29beaa

fix the button group test

212d408

use messages from the button label

cfea260

jsartisan force-pushed the fix/failing-button-group branch from ef6ef09 to cfea260 Compare May 7, 2024 11:19

fix prettier issue

c613aff

jsartisan requested review from mohanarpit and ankitakinger May 7, 2024 11:56

use messages variable in configs

af27a00

update Something to something

d58e403

jsartisan enabled auto-merge (squash) May 7, 2024 12:20

ankitakinger reviewed May 7, 2024

View reviewed changes

revert limited-tests file

667b7d1

jsartisan requested a review from ankitakinger May 7, 2024 12:40

ankitakinger approved these changes May 7, 2024

View reviewed changes

jsartisan added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels May 7, 2024

jsartisan merged commit 6a6e494 into release May 7, 2024
42 checks passed

jsartisan deleted the fix/failing-button-group branch May 7, 2024 13:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: button group spec #33234

fix: button group spec #33234

jsartisan commented May 7, 2024 •

edited by github-actions bot

Loading

coderabbitai bot commented May 7, 2024 •

edited

Loading

Walkthrough

Changes

Possibly related issues

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

jsartisan commented May 7, 2024

github-actions bot commented May 7, 2024

mohanarpit May 7, 2024

jsartisan May 7, 2024

mohanarpit May 7, 2024

mohanarpit May 7, 2024

jsartisan May 7, 2024

jsartisan May 7, 2024

jsartisan May 7, 2024

jsartisan commented May 7, 2024

github-actions bot commented May 7, 2024

coderabbitai bot left a comment

github-actions bot commented May 7, 2024

jsartisan commented May 7, 2024

github-actions bot commented May 7, 2024

github-actions bot commented May 7, 2024

jsartisan commented May 7, 2024

github-actions bot commented May 7, 2024

github-actions bot commented May 7, 2024

ankitakinger May 7, 2024

jsartisan May 7, 2024

		agHelper.TypeText("//*[ @value='Do Something']", " New Button");
		agHelper.AssertContains("Do Something New Button");

fix: button group spec #33234

fix: button group spec #33234

Conversation

jsartisan commented May 7, 2024 • edited by github-actions bot Loading

coderabbitai bot commented May 7, 2024 • edited Loading

Walkthrough

Changes

Possibly related issues

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

jsartisan commented May 7, 2024

github-actions bot commented May 7, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jsartisan commented May 7, 2024

github-actions bot commented May 7, 2024

coderabbitai bot left a comment

Choose a reason for hiding this comment

github-actions bot commented May 7, 2024

jsartisan commented May 7, 2024

github-actions bot commented May 7, 2024

github-actions bot commented May 7, 2024

jsartisan commented May 7, 2024

github-actions bot commented May 7, 2024

github-actions bot commented May 7, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jsartisan commented May 7, 2024 •

edited by github-actions bot

Loading

coderabbitai bot commented May 7, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)