Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: font family changes to PT root in privacy and tnc pages #33992

Merged
merged 2 commits into from
Jun 5, 2024
Merged

fix: font family changes to PT root in privacy and tnc pages #33992

merged 2 commits into from
Jun 5, 2024

Conversation

albinAppsmith
Copy link
Collaborator

@albinAppsmith albinAppsmith commented Jun 5, 2024 •
edited by github-actions bot
Loading

Description

Privacy and Term & conditions pages was not using latest platform font PT root since it was served as normal HTML files. This PR addresses that issue.

Fixes #33427

Automation

/ok-to-test tags="@tag.Sanity"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9382277755
Commit: 75416ef
Cypress dashboard url: Click here!

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • New Features

    • Introduced new font styling across various pages using the PT Root UI font family for a consistent look and feel.

  • Style

    • Updated 404.html, privacy-policy.html, and terms-and-conditions.html to include a link to the new font-style.css stylesheet.
    • Removed redundant font-family declarations from privacy-policy.html and terms-and-conditions.html.

  • Documentation

    • Added licence.txt for the PT Root UI font, detailing the SIL Open Font License.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 5, 2024 •
edited
Loading

Walkthrough

This update introduces new font styling across several HTML files to ensure consistent and modern typography. The main changes include adding a new font-style.css stylesheet, integrating the PT Root UI font family, and updating the Privacy Policy and Terms and Conditions pages to use the new fonts.

Changes

Files Change Summary
app/client/public/404.html Added a new <link> tag referencing font-style.css.
app/client/public/font-style.css Introduced styling for the body element, including font settings and letter spacing.
app/client/public/privacy-policy.html Added a new stylesheet link (font-style.css) and removed font-family declarations.
app/client/public/static/font/licence.txt Added the SIL Open Font License Version 1.1 for the font "PT Root UI".
app/client/public/static/font/pt-root-ui.css Added font-face declarations for PT Root UI font family with various weights.
app/client/public/terms-and-conditions.html Added a link to font-style.css and removed font-family styling from the body element.

Assessment against linked issues

Objective (Issue #33427) Addressed Explanation
Privacy policy and Terms and Conditions pages fonts are not updated. ✅

Poem

In code's embrace, fonts find their place,
With PT Root UI, a stylish grace.
Policies and terms now shine so bright,
In every byte, they take their flight.
A rabbit's touch, in CSS's might,
Makes web pages a delightful sight.
🌟🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added ads revamp All issues related to ads revamp. Bug Something isn't working Design System Product Appsmith design system related issues IDE Product Issues related to the IDE Product Low An issue that is neither critical nor breaks a user flow Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage IDE Pod Issues that new developers face while exploring the IDE Production labels Jun 5, 2024
@albinAppsmith albinAppsmith added the ok-to-test Required label for CI label Jun 5, 2024
@albinAppsmith
Copy link
Collaborator Author

/build-deploy-preview skip-test=true

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2024

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/9382284959.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 33992.
recreate: .

coderabbitai[bot]
coderabbitai bot reviewed Jun 5, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 36043fa and 75416ef.

Files ignored due to path filters (9)
  • app/client/public/static/font/pt-root-ui_bold.woff is excluded by !**/*.woff
  • app/client/public/static/font/pt-root-ui_bold.woff2 is excluded by !**/*.woff2
  • app/client/public/static/font/pt-root-ui_light.woff is excluded by !**/*.woff
  • app/client/public/static/font/pt-root-ui_light.woff2 is excluded by !**/*.woff2
  • app/client/public/static/font/pt-root-ui_medium.woff is excluded by !**/*.woff
  • app/client/public/static/font/pt-root-ui_medium.woff2 is excluded by !**/*.woff2
  • app/client/public/static/font/pt-root-ui_regular.woff is excluded by !**/*.woff
  • app/client/public/static/font/pt-root-ui_regular.woff2 is excluded by !**/*.woff2
  • app/client/public/static/font/pt-root-ui_semi-bold.woff2 is excluded by !**/*.woff2
Files selected for processing (6)
  • app/client/public/404.html (1 hunks)
  • app/client/public/font-style.css (1 hunks)
  • app/client/public/privacy-policy.html (2 hunks)
  • app/client/public/static/font/licence.txt (1 hunks)
  • app/client/public/static/font/pt-root-ui.css (1 hunks)
  • app/client/public/terms-and-conditions.html (1 hunks)
Files skipped from review due to trivial changes (4)
  • app/client/public/404.html
  • app/client/public/font-style.css
  • app/client/public/static/font/pt-root-ui.css
  • app/client/public/terms-and-conditions.html
Additional context used
LanguageTool
app/client/public/static/font/licence.txt

[typographical] ~11-~11: If you want to indicate numerical ranges or time ranges, consider using an en dash. (DASH_RULE)
Context: ...------ SIL OPEN FONT LICENSE Version 1.1 - 26 February 2007 -----------------------...

Additional comments not posted (2)
app/client/public/static/font/licence.txt (1)

1-95: The addition of the SIL Open Font License in licence.txt is appropriate and well-documented. This ensures compliance with the licensing requirements for the newly added PT Root UI font, which is crucial for legal use and redistribution.

Tools
LanguageTool

[typographical] ~11-~11: If you want to indicate numerical ranges or time ranges, consider using an en dash. (DASH_RULE)
Context: ...------ SIL OPEN FONT LICENSE Version 1.1 - 26 February 2007 -----------------------...

app/client/public/privacy-policy.html (1)

6-6: The addition of the font-style.css stylesheet link in the privacy-policy.html is correctly implemented. This change is essential for ensuring that the PT Root UI font is applied consistently across the Privacy Policy page, aligning with the PR's objectives to update the font across platform documents.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2024

Deploy-Preview-URL: https://ce-33992.dp.appsmith.com

@albinAppsmith albinAppsmith merged commit f38415c into release Jun 5, 2024
46 of 47 checks passed
@albinAppsmith albinAppsmith deleted the font-privacy-page branch June 5, 2024 10:51
@github-actions github-actions bot added QA Needs QA attention QA Pod Issues under the QA Pod labels Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@hetunandu hetunandu hetunandu approved these changes

Assignees
No one assigned
Labels
ads revamp All issues related to ads revamp. Bug Something isn't working Design System Product Appsmith design system related issues IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Low An issue that is neither critical nor breaks a user flow Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage ok-to-test Required label for CI Production QA Pod Issues under the QA Pod QA Needs QA attention
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Privacy policy and Terms and Conditions pages fonts are not updated.
3 participants
@albinAppsmith @hetunandu @Nikhil-Nandagopal