Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: vanishing widgets in protected branches #34129

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

brayn003
Copy link
Contributor

@brayn003 brayn003 commented Jun 10, 2024

Description

Fixing vanishing widgets in protected branches

Fixes #34128

Automation

/ok-to-test tags="@tag.Git"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9448976837
Commit: b45f21e
Cypress dashboard url: Click here!

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • Refactor
    • Simplified logic by removing unnecessary checks for protected mode.

@github-actions github-actions bot added Bug Something isn't working Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage Production labels Jun 10, 2024
@brayn003 brayn003 changed the title fix: drop target component wrapper fix: vanishing widgets in protected branches Jun 10, 2024
Copy link
Contributor

coderabbitai bot commented Jun 10, 2024

Walkthrough

The recent change in DropTargetComponentWrapper.tsx simplifies the logic by removing the protectedModeSelector import and eliminating the associated conditional check. This addresses the issue of disappearing widgets in protected branches by streamlining the code.

Changes

Files Change Summary
app/client/src/layoutSystems/common/dropTarget/DropTargetComponentWrapper.tsx Removed the import of protectedModeSelector and simplified the logic by eliminating isProtectedMode check.

Assessment against linked issues

Objective (Issue #34128) Addressed Explanation
Fix disappearing widgets in protected branches

Poem

In the code where widgets hide,
A change was made with simple pride.
No more checks for modes protected,
Now the widgets stay connected.
Bugs be gone, let code be tight,
In the branches, all is right.
🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added Git Platform Issues related to the git & the app platform Git Product Issues related to version control product labels Jun 10, 2024
@brayn003 brayn003 self-assigned this Jun 10, 2024
@brayn003 brayn003 marked this pull request as ready for review June 10, 2024 10:38
@brayn003 brayn003 added the ok-to-test Required label for CI label Jun 10, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 5f0f104 and b45f21e.

Files selected for processing (1)
  • app/client/src/layoutSystems/common/dropTarget/DropTargetComponentWrapper.tsx (2 hunks)
Files skipped from review due to trivial changes (1)
  • app/client/src/layoutSystems/common/dropTarget/DropTargetComponentWrapper.tsx

@brayn003 brayn003 added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels Jun 10, 2024
@brayn003 brayn003 requested a review from sneha122 June 10, 2024 11:14
@brayn003 brayn003 added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels Jun 10, 2024
@brayn003 brayn003 merged commit 068847d into release Jun 10, 2024
129 of 133 checks passed
@brayn003 brayn003 deleted the fix/protected-vanishing-widgets branch June 10, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Git Platform Issues related to the git & the app platform Git Product Issues related to version control product Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage ok-to-test Required label for CI Production
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Disappearing widgets in protected branches
2 participants