Skip to content
This repository has been archived by the owner on Aug 6, 2024. It is now read-only.

chore: Adding color icon for google #722

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Conversation

ankitakinger
Copy link
Contributor

@ankitakinger ankitakinger commented Apr 12, 2024

Description

Adding color icon for google to use on login/signup pages on Appsmith.

Fixes #32267

Depends on #32641

Type of change

  • Chore (housekeeping or task changes that don't impact user perception)

How Has This Been Tested?

  • Manual on storybook
  • Manual on main repo
  • Jest
  • Cypress

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

QA activity:

  • Test plan has been approved by relevant developers
  • Test plan has been peer reviewed by QA
  • Cypress test cases have been added and approved by either SDET or manual QA
  • Organized project review call with relevant stakeholders after Round 1/2 of QA
  • Added Test Plan Approved label after reveiwing all Cypress test

Copy link

changeset-bot bot commented Apr 12, 2024

🦋 Changeset detected

Latest commit: 5f0a73e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@appsmithorg/design-system Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 12, 2024 6:10am

@ankitakinger
Copy link
Contributor Author

/ok-to-test

@ankitakinger
Copy link
Contributor Author

/build-deploy-preview skip-tests=true

@ankitakinger
Copy link
Contributor Author

/generate-alpha

@albinAppsmith
Copy link
Contributor

/generate-alpha

@ankitakinger
Copy link
Contributor Author

@albinAppsmith The changes look good on the below DP:
https://ce-32641.dp.appsmith.com/

Can we go ahead and merge this PR in?

@albinAppsmith albinAppsmith merged commit 0662332 into release Apr 12, 2024
12 checks passed
@albinAppsmith albinAppsmith deleted the chore/add-google-icon branch April 12, 2024 08:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: update the login and signup screen for Cloud users
2 participants