Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs for deploy to OpenShift #355

Closed
wants to merge 3 commits into from
Closed

docs for deploy to OpenShift #355

wants to merge 3 commits into from

Conversation

tnixa
Copy link
Contributor

@tnixa tnixa commented Nov 7, 2019

Checklist

  • commit message follows commit guidelines.
  • website builds and runs in production - for information on how to test locally go here.

Description

Documentation for appsody deploy to local OpenShift environment

Related Issues

fixes #354

@tnixa tnixa requested a review from chilanti November 7, 2019 22:26
helenmasters
helenmasters reviewed Nov 11, 2019
View reviewed changes
content/docs/using-appsody/building-and-deploying.md Outdated
```
vi /etc/docker/certs.d/default-route-openshift-image-registry.apps-crc.testing/ca.crt
```
- Insert the copied certificate using `i` to get into insert mode and then paste the copied certificate and then press `esc` then `:wq` `<enter>` to save the file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

esc -> Esc

helenmasters
helenmasters requested changes Nov 11, 2019
View reviewed changes
Copy link
Contributor

@helenmasters helenmasters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot merge this into the deployment doc, as the current doc is already in need of splitting up.
I'd also question whether this is more of a tutorial?
I'll raise an issue now to work on splitting out deployment referencing this PR and issue.

@tnixa
Copy link
Contributor Author

tnixa commented Nov 11, 2019

We cannot merge this into the deployment doc, as the current doc is already in need of splitting up.
I'd also question whether this is more of a tutorial?
I'll raise an issue now to work on splitting out deployment referencing this PR and issue.

I wasn't sure where this fit either. I think we have a "Tekton Example" so maybe this is more of an "Example"? But it is a deployment environment so it does seem to fit in with the other deployment stuff.

@skoh7645
Copy link
Collaborator

skoh7645 commented Apr 7, 2020

Closing this for now and this PR contains a lot of non-Appsody specific documentation. We will include the relevant parts of this PR in the fix for #359

@skoh7645 skoh7645 closed this Apr 7, 2020
@skoh7645 skoh7645 reopened this Apr 7, 2020
@skoh7645
Copy link
Collaborator

skoh7645 commented Apr 7, 2020

Reopening in hopes to verify and simplify this PR

@neeraj-laad
Copy link
Contributor

Closing as no longer relevant. Other changes have been made to build/deploy/ and reference sections that cover this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helenmasters helenmasters helenmasters requested changes

@chilanti chilanti Awaiting requested review from chilanti

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

instructions for running appsody on OpenShift Red Hat CodeReady Containers
4 participants
@tnixa @skoh7645 @neeraj-laad @helenmasters