Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend system idea with graphical user interface and API endpoint #24

Merged
merged 5 commits into from
Sep 17, 2021
Merged

Extend system idea with graphical user interface and API endpoint #24

merged 5 commits into from
Sep 17, 2021

Conversation

corvus-ch
Copy link
Contributor

@corvus-ch corvus-ch commented Sep 15, 2021 •
edited
Loading

Checklist

  • Try to isolate changes into separate PRs (to build a better changelog).
  • Categorize the PR by setting a good title and adding one of the labels:
    change, decision, requirement/quality, requirement/functional, dependency
    as they show up in the changelog

@corvus-ch corvus-ch self-assigned this Sep 15, 2021
tobru
tobru requested changes Sep 16, 2021
View reviewed changes
Copy link
Member

@tobru tobru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes are needed, but the overall direction is perfect. Thanks a lot.

docs/modules/ROOT/pages/explanation/system/idea.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/explanation/system/idea.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/explanation/system/idea.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/explanation/system/idea.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/explanation/system/idea.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/explanation/system/details-ui.adoc Show resolved Hide resolved
docs/modules/ROOT/pages/explanation/system/details-ui.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/explanation/system/details-ui.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/explanation/system/details-external-services.adoc Outdated Show resolved Hide resolved
@tobru tobru mentioned this pull request Sep 16, 2021
Closed
2 tasks
@ccremer ccremer changed the title Idea for cross zone concernes user interface Extend Systemidea with graphical user interface and API endpoint Sep 16, 2021
@ccremer ccremer changed the title Extend Systemidea with graphical user interface and API endpoint Extend system idea with graphical user interface and API endpoint Sep 16, 2021
tobru
tobru approved these changes Sep 16, 2021
View reviewed changes
Copy link
Member

@tobru tobru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose to document the official name here so that we can start talking about it more easily. Other than that, it looks good to me now.

@corvus-ch corvus-ch added change A generic change or typos requirement/functional Feature requirement labels Sep 17, 2021
@corvus-ch @tobru
Apply suggestions from code review
82764a8 
Co-authored-by: Tobias Brunner <tobias.brunner@vshn.ch>
@corvus-ch corvus-ch marked this pull request as ready for review September 17, 2021 07:18
@corvus-ch corvus-ch merged commit 668e442 into master Sep 17, 2021
@ccremer ccremer removed the change A generic change or typos label Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccremer ccremer ccremer left review comments

@tobru tobru tobru approved these changes

Assignees

@corvus-ch corvus-ch

Labels
requirement/functional Feature requirement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@corvus-ch @tobru @ccremer