Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add empty plugins list by default #50

Merged
merged 2 commits into from
Feb 22, 2023
Merged

Add empty plugins list by default #50

merged 2 commits into from
Feb 22, 2023

Conversation

anothertobi
Copy link
Contributor

Checklist

  • The PR has a meaningful title. It will be used to auto generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.

Copy link
Member

@simu simu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

component/main.jsonnet Outdated Show resolved Hide resolved
Co-authored-by: Simon Gerber <simon.gerber@vshn.ch>
@anothertobi anothertobi merged commit ef6430f into master Feb 22, 2023
@anothertobi anothertobi deleted the default-plugins branch February 22, 2023 13:49
anothertobi added a commit that referenced this pull request Feb 23, 2023
This partially reverts the changes of #50 to only manage plugins through
this component since patching a list from multiple sources is not
possible with the current tooling.

See appuio/component-openshift4-logging#97 for
an alternative approach.
anothertobi added a commit that referenced this pull request Feb 23, 2023
This partially reverts the changes of #50 to only manage plugins through
this component since patching a list from multiple sources is not
possible with the current tooling.

See appuio/component-openshift4-logging#97 for
an alternative approach.
@anothertobi anothertobi mentioned this pull request Feb 23, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants