Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconcile even if no EmailSent condition can be found #121

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Reconcile even if no EmailSent condition can be found #121

merged 1 commit into from
Mar 8, 2023

Conversation

bastjan
Copy link
Contributor

@bastjan bastjan commented Mar 8, 2023 •
edited
Loading

  • Use native error back-off functions.
  • Fix (unused) event recorder name
  • Implement Condition.Reason as expected by the API.

Checklist

  • PR contains a single logical change (to build a better changelog).
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.

@bastjan
Reconcile even if no EmailSent condition can be found.
a9584ef 
- Use native error back-off functions.
- Fix (unused) event recorder name
@bastjan bastjan added the bug Something isn't working label Mar 8, 2023
@bastjan bastjan changed the title Reconcile even if no EmailSent condition can be found. Reconcile even if no EmailSent condition can be found Mar 8, 2023
HappyTetrahedron
HappyTetrahedron approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@HappyTetrahedron HappyTetrahedron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as we have discussed it in person

@bastjan bastjan merged commit 9587b52 into master Mar 8, 2023
@bastjan bastjan deleted the reconcile-fixes branch March 8, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HappyTetrahedron HappyTetrahedron HappyTetrahedron approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bastjan @HappyTetrahedron