General refactor of cleanup commands #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was not used or implemented
- Imagestream is an OpenShift specific term. - with the new 'orphan' command, this is now more separable.
Reduces CI jobs, simplifies local build too
Copy-pasting image tags is cumbersome with logging framework in a single line.
To align with orphan mode
Go modules tend to be rather flat as opposed to the Java/python style hierarchies
It actually seems to be the case that the pkg dir is a convention for CLI/cobra tools
It must have gotten lost during the refacotirng
The flags were parsed for orphan, but not history
srueg
suggested changes
Mar 19, 2020
|
There are now a number of commits. Should I squash them all together, or try to separate some aspects of it, to keep the thought process a bit (although I won't make sure that the individual commits still compile)? |
srueg
approved these changes
Mar 20, 2020
|
Actually I'll do a separate PR for the rename |
bittner
reviewed
Mar 25, 2020
| os.Exit(1) | ||
| cmd.SetVersion(fmt.Sprintf("%s, commit %s, date %s", version, commit, date)) | ||
| if err := cmd.Execute(); err != nil { | ||
| log.WithError(err).Fatal("Command aborted.") |
There was a problem hiding this comment.
When I approach the CLI as a noob my first impression is that the user feedback is intimidating. The CLI fails hard when an argument is not or not correctly provided.
I would suggest a more typical approach, which is simply showing the usage, like e.g. the hugo CLI client does it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.