Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix README badges, more context and structure #15

Merged
merged 2 commits into from
Mar 25, 2020
Merged

Fix README badges, more context and structure #15

merged 2 commits into from
Mar 25, 2020

Conversation

bittner
Copy link
Contributor

@bittner bittner commented Mar 24, 2020

  • Makes the colorful badges on top of the README clickable.
  • Tries to introduce more structure for an easier read.
  • Gives more cohesive context and history.

Some of the described features are pending implementation, so this PR can either wait or the feature implementation be followed up quickly after merging.

Follow-up on: #14

@bittner bittner requested a review from ccremer March 24, 2020 23:05
ccremer
ccremer suggested changes Mar 25, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@bittner bittner requested a review from ccremer March 25, 2020 11:24
@bittner
Copy link
Contributor Author

bittner commented Mar 25, 2020

I removed the future bits with a separate commit. We may want to bring those changes back later, one day, maybe. 👍

ccremer
ccremer approved these changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@ccremer ccremer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Let's merge it now. We don't know when we have finished the secrets/cm feature, it may take a while until then.

@ccremer ccremer merged commit cd1dfa2 into master Mar 25, 2020
@bittner bittner deleted the readme/fix-badges-explain-context branch March 25, 2020 16:03
@bittner
Copy link
Contributor Author

bittner commented Mar 25, 2020

Thank you! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccremer ccremer ccremer approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bittner @ccremer