Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup empty namespaces #53

Merged
merged 11 commits into from
May 7, 2021
Merged

Cleanup empty namespaces #53

merged 11 commits into from
May 7, 2021

Conversation

srueg
Copy link
Contributor

@srueg srueg commented Apr 20, 2021 •
edited by cimnine
Loading

Summary

Cleanup empty namespaces.

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking,
    as they show up in the changelog
  • Update the documentation.
  • Update tests.

@srueg srueg added the enhancement New feature or request label Apr 20, 2021
@srueg srueg force-pushed the cleanup-ns branch 2 times, most recently from 6ffc48e to 4c1ace0 Compare April 20, 2021 12:31
@srueg srueg requested a review from ccremer April 20, 2021 12:32
@srueg
Cleanup empty namespaces
357ec6b 
Signed-off-by: Simon Rüegg <simon@rueggs.ch>
@srueg
Update GH actions
a812a85 
A full build of all platforms and architectures takes too long (up to 8
minutes) and has no real benefit over running just the tests.
ccremer
ccremer reviewed Apr 20, 2021
View reviewed changes
Copy link
Contributor

@ccremer ccremer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review is probably note-to-self :)

Might make sense to add integration tests or even e2e tests with KIND, seeing that helm testing fails.

pkg/namespace/namespace.go Outdated Show resolved Hide resolved
pkg/namespace/namespace_test.go Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
cmd/namespace_test.go Outdated Show resolved Hide resolved
cimnine
cimnine reviewed May 3, 2021
View reviewed changes
cmd/namespaces.go Outdated Show resolved Hide resolved
@cimnine @ccremer
Fix typos
24810bf 
Co-authored-by: Chris <github.account@chrigel.net>
@cimnine cimnine marked this pull request as ready for review May 4, 2021 15:11
@cimnine cimnine requested a review from ccremer May 4, 2021 15:11
@cimnine cimnine self-assigned this May 6, 2021
@cimnine cimnine requested a review from simu May 6, 2021 11:47
simu
simu approved these changes May 6, 2021
View reviewed changes
Copy link
Member

@simu simu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see any obvious problems in the code and the deletion logic looks correct.

ccremer
ccremer suggested changes May 6, 2021
View reviewed changes
cmd/namespaces.go Outdated Show resolved Hide resolved
pkg/namespace/namespace.go Outdated Show resolved Hide resolved
pkg/namespace/namespace.go Outdated Show resolved Hide resolved
cmd/namespaces.go Show resolved Hide resolved
@cimnine cimnine requested a review from ccremer May 7, 2021 11:28
@cimnine cimnine merged commit dbf5fec into master May 7, 2021
@cimnine cimnine deleted the cleanup-ns branch May 7, 2021 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cimnine cimnine cimnine left review comments

@ccremer ccremer ccremer approved these changes

@simu simu simu approved these changes

Assignees

@cimnine cimnine

Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@srueg @simu @cimnine @ccremer