Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commit tag support #9

Merged
merged 3 commits into from
Jan 14, 2020
Merged

Add commit tag support #9

merged 3 commits into from
Jan 14, 2020

Conversation

zugao
Copy link
Contributor

@zugao zugao commented Jan 3, 2020

Added support for commit tags. For instruction how to use commit tags instead of commit hashes run ./image-cleanup imagestream --help after building it.

Added several tests and updated the matching logic between commits and image stream tags:

  • commit type hash -> prefix matching
  • commit type tag -> full matching (equals)

If I missed something please comment.

@zugao zugao requested a review from srueg January 3, 2020 15:10
pkg/git/git.go Show resolved Hide resolved
@zugao
Copy link
Contributor Author

zugao commented Jan 8, 2020

Added a new commit with new flag --sorted-by

@anothertobi anothertobi self-requested a review January 9, 2020 09:26
pkg/cleanup/cleanup.go Outdated Show resolved Hide resolved
pkg/cleanup/cleanup.go Outdated Show resolved Hide resolved
pkg/git/git.go Outdated Show resolved Hide resolved
pkg/git/sort_by_tag.go Outdated Show resolved Hide resolved
pkg/git/sort_by_tag.go Outdated Show resolved Hide resolved
pkg/git/sort_by_tag.go Outdated Show resolved Hide resolved
pkg/git/sort_by_tag.go Outdated Show resolved Hide resolved
pkg/git/git.go Outdated Show resolved Hide resolved
cmd/imagestream.go Outdated Show resolved Hide resolved
pkg/git/git_test.go Show resolved Hide resolved
cmd/imagestream.go Outdated Show resolved Hide resolved
cmd/imagestream.go Show resolved Hide resolved
pkg/cleanup/cleanup.go Outdated Show resolved Hide resolved
pkg/git/sort_by_tag.go Outdated Show resolved Hide resolved
cmd/imagestream.go Outdated Show resolved Hide resolved
cmd/imagestream.go Outdated Show resolved Hide resolved
@zugao zugao force-pushed the feature/release-tag-support branch from 8a052dc to 69bf075 Compare January 9, 2020 14:21
@zugao zugao merged commit 555ecd1 into master Jan 14, 2020
@zugao zugao deleted the feature/release-tag-support branch January 14, 2020 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants