Remove the fill attribute from all icons #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windvis
added
the
bug
Windvis
commented
Mar 27, 2024
| @@ -1,5 +1 @@ | |||
| <svg xmlns="http://www.w3.org/2000/svg" fill="currentColor" viewBox="0 0 24 24"> | |||
There was a problem hiding this comment.
This one wasn't really a problem since we also use currentColor but it seemed better to remove it for consistency.
The fill attribute prevents the icon from receiving the proper coloring. This wasn't an issue in the symbolset version because svg-symbols strips the attribute.
Windvis
force-pushed
the
fix/icon-components-with-fill
branch
from
e0691b1
to
55ad8a2
Compare
|
Released in v3.4.1 |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fill attribute prevents the icon from receiving the proper coloring. This wasn't an issue in the symbolset version because svg-symbols strips the attribute.
Part of #482