Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: expired session, schedule deletes #4860

Merged
merged 5 commits into from
Dec 14, 2022
Merged

Fix: expired session, schedule deletes #4860

merged 5 commits into from
Dec 14, 2022

Conversation

Meldiron
Copy link
Contributor

@Meldiron Meldiron commented Dec 14, 2022 •
edited
Loading

What does this PR do?

Fixes:

  • delete worker deleting schedules for existing functions
  • expired session deletion having syntax error after merge conflict
  • Prepared patch CLI script for missing schedule documents

Test Plan

  • Manual QA

Related PRs and Issues

x

Have you added your change to the Changelog?

Not user facing chage

Have you read the Contributing Guidelines on issues?

Yes

@Meldiron Meldiron marked this pull request as ready for review December 14, 2022 08:46
@Meldiron Meldiron mentioned this pull request Dec 14, 2022
Closed
eldadfux
eldadfux requested changes Dec 14, 2022
View reviewed changes
src/Appwrite/Platform/Services/Tasks.php Outdated Show resolved Hide resolved
docker-compose.yml Show resolved Hide resolved
@Meldiron Meldiron merged commit 54c6f9f into feat-db-pools Dec 14, 2022
@Meldiron Meldiron deleted the fix-deletes-worker-tasks branch December 14, 2022 10:29
@stnguyen90 stnguyen90 mentioned this pull request Dec 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldadfux eldadfux eldadfux approved these changes

@shimonewman shimonewman shimonewman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Meldiron @eldadfux @shimonewman