Update filterable subscriber columns #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't allow filtering on userName since the attribute isn't in the collection to be filtered. Allow filtering on type since it is available and it would be userful. Change $createdAt type to datetime to allow filtering by greater/less than.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
TorstenDittmann
approved these changes
Jan 17, 2024
This was referenced Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Don't allow filtering on userName since the attribute isn't in the collection to be filtered.
Allow filtering on type since it is available and it would be userful.
Change $createdAt type to datetime to allow filtering by greater/less than.
Test Plan
Filters show the columns:
And I was able to manually filter on each column.
Related PRs and Issues
Parent:
Have you read the Contributing Guidelines on issues?
Yes