Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Function Runtimes Checklist #53

Merged
merged 12 commits into from
Jul 25, 2022
Merged

Conversation

adityaoberai
Copy link
Member

No description provided.

@adityaoberai adityaoberai marked this pull request as ready for review June 29, 2022 10:17
Copy link
Member

@eldadfux eldadfux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @adityaoberai - left some comments.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@adityaoberai
Copy link
Member Author

@eldadfux having read the open-runtimes tutorial, I'll modify all the substeps in the first point based on the guide. It does seem to cover them all.

@adityaoberai
Copy link
Member Author

@eldadfux I have updated the checklist
Can you please give it a look once?

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@Meldiron
Copy link
Contributor

We probably need this updated with: https://github.com/open-runtimes/open-runtimes/pull/74/files

It adds support for logs.

Copy link
Contributor

@Meldiron Meldiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TorstenDittmann TorstenDittmann merged commit cf3c466 into main Jul 25, 2022
@TorstenDittmann TorstenDittmann deleted the add-function-checklist branch July 25, 2022 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants