Close Android realtime socket properly on unsubscribe #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes Android realtime socket cleanup - last subscription was always active even after unsubscribing.
Test Plan
Inspecting network, simple breakpoint in onMessage function and observing realtime count indicator in Appwrite dashboard revealed that realtime connection is still active and data is coming through even after disconnecting.
After the fix, socket is closed properly and Appwrite dashboard confirms it as well.
Related PRs and Issues
Similar issue found on sdk-for-web -> #809
Have you read the Contributing Guidelines on issues?
Yes