Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: CLI folder name (functions) #832

Merged
merged 4 commits into from
May 16, 2024
Merged

Conversation

Meldiron
Copy link
Contributor

@Meldiron Meldiron commented May 13, 2024

What does this PR do?

Use function ID for the folder name so that:

  1. it's more consistent with the rest of Appwrite
  2. the function name can have special characters that cause problems for folders

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

@byawitz byawitz requested review from stnguyen90 and loks0n May 13, 2024 22:45
Copy link
Contributor Author

@Meldiron Meldiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@byawitz byawitz changed the base branch from master to feat-cli-g2 May 15, 2024 16:05
@christyjacob4 christyjacob4 merged commit 36a37b8 into feat-cli-g2 May 16, 2024
34 checks passed
@byawitz byawitz deleted the fix-cli-func-folder-name branch May 17, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants