Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Removed alt attributes in cards #303

Merged
merged 12 commits into from
Nov 6, 2023
Merged

Conversation

Sweetdevil144
Copy link
Contributor

What does this PR do?

Removes alt attributes from cards in this section of website.

An empty alt attribute hides the image from assistive technology so it does not add unnecessary noise within the link. Removing the alt attribute would result in the images URL being read out which would make the problem worse!
(Provide a description of what this PR does.)

Related PRs and Issues

Fixes #284
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

Yes
(Write your answer here.)

@vercel
Copy link

vercel bot commented Oct 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2023 5:30pm

@Sweetdevil144
Copy link
Contributor Author

@TGlide can you review it?

Copy link
Contributor

@TGlide TGlide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The images seem to be missing:
image

src/routes/docs/tutorials/+page.svelte Outdated Show resolved Hide resolved
src/routes/docs/+page.svelte Outdated Show resolved Hide resolved
Copy link
Contributor

@TGlide TGlide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! It looks great now 🎉

I appreciate the quick responses to my several comments, thank you for the patience and the contribution! 😄

@TGlide TGlide merged commit df3eef3 into appwrite:main Nov 6, 2023
1 check passed
@gewenyu99
Copy link
Contributor

Hey there! There were a lot of big PRs during this Hacktoberfest, and we wanted to give everyone ample time to collaborate with our engineering team. If you were able to merge your PRs during October, amazing. If it’s still not merged, don’t worry about it either. Either way, we’ve got your Hacktoberfest swag minted and ready to ship.

Please comment with your Discord username here so we can contact you about your shipping information to deliver your Hacktoberfest swag.

@Sweetdevil144
Copy link
Contributor Author

Hey,

Sweetdevil144#8236

Thanks :)

@Sweetdevil144
Copy link
Contributor Author

@gewenyu99 Updates?

@gewenyu99
Copy link
Contributor

@gewenyu99 Updates?

Will reach out soon. Putting some last things together. Appreciate the patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📚 Documentation: images in cards should have empty alt attributes [a11y][TheA11y100]
4 participants