Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP-6242 OrderItem does not follow documented v4 API #29

Merged
merged 3 commits into from
Oct 30, 2017
Merged

Conversation

dbelling
Copy link
Contributor

This one flew under the radar for a while - our gem now meshes with the documented attributes for OrderItems in our API.

Copy link
Contributor

@tommycrumrine tommycrumrine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one small fix.

@@ -10,7 +10,7 @@
subject { line_item }

it { should respond_to(:title) }
it { should respond_to(:amount_cents) }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L7 here uses amount_cents GitHub won't let me comment there

@dbelling dbelling merged commit 701165b into master Oct 30, 2017
@dbelling dbelling deleted the AP-6242 branch October 30, 2017 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants