Breaking/v0.4.0 #47
Breaking/v0.4.0 #47
Conversation
Issue 39 pass fail cleanup
Refactor service wrapping
commit 2754735 Author: Noah Callaway <noah@apsis.io> Date: Tue Mar 14 22:56:21 2017 -0700 Make rubocop happy commit c40d517 Author: Noah Callaway <noah@apsis.io> Date: Tue Mar 14 22:49:39 2017 -0700 Service result machinery commit a828f03 Author: Noah Callaway <noah@apsis.io> Date: Tue Mar 14 22:29:41 2017 -0700 Service Result Machinery
Upgrade rubocop
| pass value: m | ||
| end | ||
|
|
||
| def self.mul(x, y) |
There was a problem hiding this comment.
Naming/UncommunicativeMethodParamName: Method parameter must be at least 3 characters long.
| @@ -0,0 +1,15 @@ | |||
| class MultiplyingService < Slayer::Service | |||
| def inst_mul(x, y) | |||
There was a problem hiding this comment.
Naming/UncommunicativeMethodParamName: Method parameter must be at least 3 characters long.
test/fixtures/hooks/only_hook.rb
Outdated
| def c; end | ||
| def self.c; end | ||
|
|
||
| def self.wrapper(_, _instance, wrapper_block) |
There was a problem hiding this comment.
Naming/UncommunicativeMethodParamName: Method parameter must be at least 3 characters long.
test/fixtures/hooks/skip_hooks.rb
Outdated
| def c; end | ||
| def self.c; end | ||
|
|
||
| def self.wrapper(_, _instance, wrapper_block) |
There was a problem hiding this comment.
Naming/UncommunicativeMethodParamName: Method parameter must be at least 3 characters long.
test/fixtures/hooks/simple_hook.rb
Outdated
| def simple; end | ||
| def self.simple; end | ||
|
|
||
| def self.wrapper(_, _instance, wrapper_block) |
There was a problem hiding this comment.
Naming/UncommunicativeMethodParamName: Method parameter must be at least 3 characters long.
lib/slayer/service.rb
Outdated
|
|
||
| return @transitive_dependencies | ||
| # rubocop:disable Metrics/MethodLength | ||
| def self.__service_hook(_, instance, service_block) |
There was a problem hiding this comment.
Naming/UncommunicativeMethodParamName: Method parameter must be at least 3 characters long.
Feature/wip add cops
v0.5.0 - introduce Ruby 3 Support
No description provided.