Update SmsHandlerHook.java #68
Conversation
add Support Android Q
| XposedHelpers.findAndHookMethod(SMS_HANDLER_CLASS, lpparam.classLoader, "dispatchIntent", | ||
| /* intent */ Intent.class, | ||
| /* permission */ String.class, | ||
| /* appOp */ int.class, |
There was a problem hiding this comment.
This should be String (I think? Unless you tested this and it worked?)
There was a problem hiding this comment.
I tested it here and it works
There was a problem hiding this comment.
Hm then you must have gotten an Android build based off the code between this commit and this commit. What ROM you are using? This does not seem to be the version in the android10-release branch, and others have reported that the original code works on Android Q as-is, so this will probably break it for them.
There was a problem hiding this comment.
Huh, what do you know, they actually changed this in the middle of a version. That hasn't happened before. Okay, we need to try both versions then, that is:
try {
hookDispatchIntent29(lpparam);
} catch (NoSuchMethodError) {
hookDispatchIntent23(lpparam);
}
We might also need to make this more generic in the future, but this should suffice for now.
There was a problem hiding this comment.
Now you can compile this version, because this method was told by others, and he found that several roms are like this, if there is time, you can do it again.
There was a problem hiding this comment.
Not sure what you mean, at the very least we need to try both modes, right?
app/src/main/java/com/crossbowffs/nekosms/xposed/SmsHandlerHook.java
Outdated
Show resolved
Hide resolved
add Support Android Q