Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "type": "module" to make common js available #2

Closed
wants to merge 1 commit into from
Closed

Remove "type": "module" to make common js available #2

wants to merge 1 commit into from

Conversation

simonboisset
Copy link
Contributor

this fix this issue: #1

@goenning
Copy link
Member

Im pretty sure I had to add this to make it compatible with Next.js, so I need to verify it doesn't break it first.

By the way, just an FYI that this package only works on the client side. I have plans for a nextjs specific package which will work on both client/server, and it might be a good timing to do one for remix too.

@simonboisset
Copy link
Contributor Author

You're right, I hadn't considered Next.js compatibility.
Your idea of a Next.js specific package for client/server sounds interesting. Let me know if you need any help for that.

@goenning
Copy link
Member

Yeah, I'd definitely accept some help :)

My plan was to change this repo to be a monorepo and host all js-related packages like @aptabase/web, @aptabase/next and @aptabase/remix

The implementation is quite simple and there's probably a lot to share between them, most of the work would be on setting up the monorepo with different packages, examples, etc. Would you like to give it a try? We could start with web and remix as well

@simonboisset
Copy link
Contributor Author

simonboisset commented Jul 26, 2023

Yes sure, monorepo is really nice for js packages. I can suggest you turborepo. It works great for me.
It's not perfect but you can take a look to my repo here to see an exemple that I use to publish multiple packages.
I would also be happy to help to set up this type of configuration. I remain available if you wish

@goenning
Copy link
Member

I love that setup, would you like to PR a similar setup it to this repo?

@simonboisset
Copy link
Contributor Author

Of course i can do it in the next few days

@simonboisset
Copy link
Contributor Author

Hi!
Sorry for the delay but I was really busy this month.

I created a PR => #3
You can take a look

@goenning
Copy link
Member

goenning commented Sep 4, 2023

Closing this, let's continue on #1

@goenning goenning closed this Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants