Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disk and container attributes to database JSON output. #280

Merged
merged 1 commit into from
Mar 12, 2021

Conversation

UserNotFound
Copy link
Member

@UserNotFound UserNotFound commented Mar 12, 2021

Display the disk type and size, as well as container size, and database version when APTIBLE_OUTPUT_FORMAT=json aptible db:list is used.

[
  {
    "id": 1,
    "handle": "test",
    "type": "postgresql",
    "version": "13",
    "status": "provisioned",
    "connection_url": "postgresql://aptible:password@db-test-1.aptible.in:26187/db",
    "credentials": [
      {
        "type": "postgresql",
        "connection_url": "postgresql://aptible:password@db-test-1.aptible.in:26187/db",
        "default": true
      }
    ],
    "environment": {
      "id": 1,
      "handle": "test"
    },
    "disk_type": "gp3",
    "disk_size": 10,
    "container_size": 1024
  }
]

Copy link
Contributor

@bayley-aptible bayley-aptible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

You asked what else to include:

created_at for the db? I occasionally find this useful, maybe someone's workflow involves looking at recently-created dbs.
backup count/total size, since we're charging for it now? (don't feel strongly on this)


Fabricator(:database_disk, from: :stub_database_disk) do
size 100
ebs_volume_type { 'gb2' }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supposed to be gp2?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants