Test coverage #1090
Merged
Test coverage #1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1090 +/- ##
===========================================
+ Coverage 52.11% 66.31% +14.20%
===========================================
Files 73 141 +68
Lines 11272 15890 +4618
===========================================
+ Hits 5874 10538 +4664
+ Misses 4832 4603 -229
- Partials 566 749 +183
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Add the https redirect to the gold ouptut of the test as this was changed for the jenkins debian repos and the tests were failing after this change.
randombenj
force-pushed
the
test-coverage
branch
12 times, most recently
from
0d0ffed
to
5eb9723
Compare
To capture the coverage also for the integration tests, a test only executing the cmd.Run function is used. The test always exits with code 0 and prints the real exit code to stdout. Otherwise no coverage report is generated. Those changes enable a more accurate coverage report for future contributions.
randombenj
force-pushed
the
test-coverage
branch
from
5eb9723
to
29e7e7b
Compare
randombenj
requested review from
ximon18 and
lbolla
and removed request for
ximon18
dario-gallucci
approved these changes
Jul 12, 2022
lbolla
approved these changes
Jul 12, 2022
|
Thanks @randombenj, I'll try and make time to take a look. Ah I see it was already approved and merged, well I may still take a look anyway even if just to satisfy my own curiosity. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
All new code should be covered with tests, documentation should be updated. CI should pass.
Description of the Change
Add code coverage also for functional tests so contribution and maintenance of aptly becomes
simpler in the future.